public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: LoongArch: Add support for static data member in struct Date: Thu, 2 Mar 2023 14:34:50 +0000 (GMT) [thread overview] Message-ID: <20230302143450.7C7B53858CDB@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=78c7a5288e2ba8c9fd00ee948d1f20e4decb800c commit 78c7a5288e2ba8c9fd00ee948d1f20e4decb800c Author: Hui Li <lihui@loongson.cn> Date: Fri Feb 24 06:47:39 2023 +0800 gdb: LoongArch: Add support for static data member in struct As described in C++ reference [1], static data members are not part of objects of a given class type. Modified compute_struct_member () to ignore static data member so that we can get the expected result. loongson@linux:~$ cat test.c #include<stdio.h> struct struct_01 { static unsigned a; float b;}; unsigned struct_01::a = 66; struct struct_01 struct_01_val = { 99.00 }; int check_arg_struct(struct struct_01 arg) { printf("arg.a = %d\n", arg.a); printf("arg.b = %f\n", arg.b); return 0; } int main() { check_arg_struct(struct_01_val); return 0; } loongson@linux:~$ g++ -g test.c -o test++ loongson@linux:~$ gdb test++ Without this patch: ... (gdb) start ... (gdb) p check_arg_struct(struct_01_val) arg.a = 66 arg.b = 0.000000 $1 = 0 With this patch: ... (gdb) start ... (gdb) p check_arg_struct(struct_01_val) arg.a = 66 arg.b = 99.000000 $1 = 0 [1] https://learn.microsoft.com/en-us/cpp/cpp/static-members-cpp?view=msvc-170 Signed-off-by: Hui Li <lihui@loongson.cn> Reviewed-By: Tom Tromey <tom@tromey.com> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Diff: --- gdb/loongarch-tdep.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/loongarch-tdep.c b/gdb/loongarch-tdep.c index f5ddad0ba65..b380bd7e2d4 100644 --- a/gdb/loongarch-tdep.c +++ b/gdb/loongarch-tdep.c @@ -520,6 +520,10 @@ compute_struct_member (struct type *type, { for (int i = 0; i < type->num_fields (); i++) { + /* Ignore any static fields. */ + if (field_is_static (&type->field (i))) + continue; + struct type *field_type = check_typedef (type->field (i).type ()); if (field_type->code () == TYPE_CODE_INT
reply other threads:[~2023-03-02 14:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230302143450.7C7B53858CDB@sourceware.org \ --to=yangtiezhu@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).