public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.threads/multiple-successive-infcall.exp on native-gdbserver
Date: Thu,  9 Mar 2023 11:56:20 +0000 (GMT)	[thread overview]
Message-ID: <20230309115620.9950F3858D33@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f2be4eeb6ce93e4dfab259587bcaf5cb861fc25b

commit f2be4eeb6ce93e4dfab259587bcaf5cb861fc25b
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Mar 9 12:56:27 2023 +0100

    [gdb/testsuite] Fix gdb.threads/multiple-successive-infcall.exp on native-gdbserver
    
    With test-case gdb.threads/multiple-successive-infcall.exp and target board
    native-gdbserver I run into:
    ...
    (gdb) continue^M
    Continuing.^M
    [New Thread 758.759]^M
    ^M
    Thread 1 "multiple-succes" hit Breakpoint 2, main () at \
      multiple-successive-infcall.c:97^M
    97            thread_ids[tid] = tid + 2; /* prethreadcreationmarker */^M
    (gdb) FAIL: gdb.threads/multiple-successive-infcall.exp: thread=5: \
      created new thread
    ...
    
    The problem is that the new thread message doesn't match the regexp, which
    expects something like this instead:
    ...
    [New Thread 0x7ffff746e700 (LWP 570)]^M
    ...
    
    Fix this by accepting this form of new thread message.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.threads/multiple-successive-infcall.exp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/testsuite/gdb.threads/multiple-successive-infcall.exp b/gdb/testsuite/gdb.threads/multiple-successive-infcall.exp
index f33cba62855..bd037a02674 100644
--- a/gdb/testsuite/gdb.threads/multiple-successive-infcall.exp
+++ b/gdb/testsuite/gdb.threads/multiple-successive-infcall.exp
@@ -40,6 +40,9 @@ foreach_with_prefix thread {5 4 3}  {
     -re "\\\[New Thread ${hex} \\\(LWP \[0-9\]+\\\)\\\].*${gdb_prompt}" {
       pass "${after_new_thread_message}"
     }
+    -re -wrap "\\\[New Thread $decimal\\.$decimal\\\]\r\n.*" {
+      pass $gdb_test_name
+    }
   }
 }

                 reply	other threads:[~2023-03-09 11:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230309115620.9950F3858D33@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).