public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.tui/tui-nl-filtered-output.exp for remote host
Date: Mon, 13 Mar 2023 16:20:30 +0000 (GMT)	[thread overview]
Message-ID: <20230313162030.22C733858C00@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b91f16040a6a531e010fc4e798f03159832fdd6a

commit b91f16040a6a531e010fc4e798f03159832fdd6a
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 13 17:20:09 2023 +0100

    [gdb/testsuite] Fix gdb.tui/tui-nl-filtered-output.exp for remote host
    
    When running test-case gdb.tui/tui-nl-filtered-output.exp with host board
    local-remote-host-notty and target board native-gdbserver, I get:
    ...
    FAIL: gdb.tui/tui-nl-filtered-output.exp: check printf output
    ...
    
    The problem is that Term::enter_tui is returning 0, but the test-case doesn't
    check for this, and consequently runs unsupported tests.
    
    Fix this by adding the missing check.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
index 5b1d6b7d9ba..8f85ae7ce49 100644
--- a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
+++ b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp
@@ -36,7 +36,10 @@ tuiterm_env
 
 # Setup and enter TUI mode.
 Term::clean_restart 24 80
-Term::enter_tui
+if {![Term::enter_tui]} {
+    unsupported "TUI not supported"
+    return
+}
 
 # Send the command, and check the output is correctly split over
 # multiple lines.

                 reply	other threads:[~2023-03-13 16:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313162030.22C733858C00@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).