From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 358C73858C60; Mon, 13 Mar 2023 16:20:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 358C73858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678724435; bh=gVBE8ZgkLLyz2rqt72eqLUfXFtCjb5LFKEZ9c9tCIo4=; h=From:To:Subject:Date:From; b=RRncprVbxC24YSdiJgvg5LjdjJ5JB6agevin7BhU2HUXrdJOKQ3AHc6IT1X8xE/v7 J5ip5E9NykTxr8u+PBwBL9KKCbDVLZ8QE0IlgLVc0TwwO8sPLS/ibAcr6gPySESeAy NSYsYt+LiZaNjgisbBsAZfQhbuRK84hCMrbhxLNc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: b91f16040a6a531e010fc4e798f03159832fdd6a X-Git-Newrev: e1b8f529d3246b031352882c3eb85fa2ccedd02e Message-Id: <20230313162035.358C73858C60@sourceware.org> Date: Mon, 13 Mar 2023 16:20:35 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3De1b8f529d324= 6b031352882c3eb85fa2ccedd02e commit e1b8f529d3246b031352882c3eb85fa2ccedd02e Author: Tom de Vries Date: Mon Mar 13 17:20:09 2023 +0100 [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host =20 When running test-case gdb.tui/tui-layout.exp with host board local-remote-host-notty and target board native-gdbserver, I get: ... FAIL: gdb.tui/tui-layout.exp: terminal=3Ddumb: execution=3Dfalse: layou= t=3Dasm: \ layout asm (timeout) ... =20 The problem is that the test-case expects that the default "setenv TERM= dumb" has effect, which is not the case for remote host. =20 Fix this by skipping the test for remote host. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.tui/tui-layout.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/t= ui-layout.exp index c7fdb1b0c0a..13823387e72 100644 --- a/gdb/testsuite/gdb.tui/tui-layout.exp +++ b/gdb/testsuite/gdb.tui/tui-layout.exp @@ -61,6 +61,10 @@ proc test_layout_or_focus {layout_name terminal executio= n} { } =20 if {$dumb_terminal} { + if { [is_remote host] } { + # setenv TERM dummy has no effect on remote host. + return + } gdb_test "layout $layout_name" \ "Cannot enable the TUI: terminal doesn't support cursor addressing \\= \[TERM=3Ddumb\\\]" } else {