From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id BDB463858D32; Tue, 25 Apr 2023 06:33:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDB463858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682404439; bh=xtIsNao/NERTsB244gwyrchYxLpBA2IDSW3BoyNMWQU=; h=From:To:Subject:Date:From; b=pwf9z4GiAK2fYBmQvTQKIeWovr3YXC/MDs7mGHj5yJnzRI7a7rAZXzKXxSc8t+L9P +PrNnEcp1SqPr64jL/8doEYTfO8lp86UrzwRhOlmXi2REX5o+9l/TIGMdt7LRdFDPt ZV5gbJCjuUBkqfU7fevyAs1FqRSiKyUElfHrTRPk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Add warning for timeout in accept_gdb_output X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 25035d2122ea23c943f0c77360dfc0770750a2e6 X-Git-Newrev: 0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2 Message-Id: <20230425063359.BDB463858D32@sourceware.org> Date: Tue, 25 Apr 2023 06:33:59 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D0d00a5f9d429= c7cbae87b9d1057fb4f9e4ae18c2 commit 0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2 Author: Tom de Vries Date: Tue Apr 25 08:33:56 2023 +0200 [gdb/testsuite] Add warning for timeout in accept_gdb_output =20 In accept_gdb_output we have: ... timeout { # Assume a timeout means we somehow missed the # expected result, and carry on. return 0 } ... =20 The timeout is silent, and though in some places the return value is ch= ecked, this is not done consistently, and consequently there are silent timeou= ts when running the TUI testsuite (gdb.tui/*.exp and gdb.python/tui*.exp). =20 Each timeout is 10 seconds, and there are 5 in total in the TUI tests, = taking 50 seconds overall: ... real 1m0.275s user 0m10.440s sys 0m1.343s ... =20 With an entire testsuite run taking about 30 minutes, that is about 2.5= % of the time spent waiting in TUI tests. =20 Let's make the timeouts visible using a warning, such that they can be = fixed. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/lib/tuiterm.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp index 05edfe9a5b1..ff38af082da 100644 --- a/gdb/testsuite/lib/tuiterm.exp +++ b/gdb/testsuite/lib/tuiterm.exp @@ -707,6 +707,8 @@ namespace eval Term { timeout { # Assume a timeout means we somehow missed the # expected result, and carry on. + warning "timeout in accept_gdb_output" + dump_screen return 0 } }