public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix timeout in gdb.tui/completion.exp
Date: Tue, 25 Apr 2023 06:34:25 +0000 (GMT)	[thread overview]
Message-ID: <20230425063425.26ACD3858D35@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9d00d9eac6020be1be09adcc14deb72ddac485fe

commit 9d00d9eac6020be1be09adcc14deb72ddac485fe
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Apr 25 08:33:57 2023 +0200

    [gdb/testsuite] Fix timeout in gdb.tui/completion.exp
    
    With test-case gdb.tui/completion.exp, we run into:
    ...
    WARNING: timeout in accept_gdb_output
    PASS: gdb.tui/completion.exp: check focus completions
    ...
    
    The timeout happens in this command:
    ...
    Term::command "layout src"
    ...
    which waits for:
    - "(gdb) layout src", and then
    - "(gdb) ".
    
    Because the "layout src" command enables the TUI there's just a prompt.
    
    Fix this by using Term::command_no_prompt_prefix.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.tui/completion.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.tui/completion.exp b/gdb/testsuite/gdb.tui/completion.exp
index 85abd4a958b..9cf8dc2ee25 100644
--- a/gdb/testsuite/gdb.tui/completion.exp
+++ b/gdb/testsuite/gdb.tui/completion.exp
@@ -66,7 +66,7 @@ if {![Term::prepare_for_tui]} {
     return
 }
 
-Term::command "layout src"
+Term::command_no_prompt_prefix "layout src"
 Term::command "complete focus "
 Term::dump_screen
 Term::check_region_contents "check focus completions" 0 17 80 5 \

                 reply	other threads:[~2023-04-25  6:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425063425.26ACD3858D35@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).