public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove error_stream Date: Tue, 2 May 2023 15:29:09 +0000 (GMT) [thread overview] Message-ID: <20230502152909.BC501385802F@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e29e63040dd09449a21762bcacabdf31d580beee commit e29e63040dd09449a21762bcacabdf31d580beee Author: Tom Tromey <tom@tromey.com> Date: Sun Apr 16 12:40:33 2023 -0600 Remove error_stream error_stream is trivial and only used in a couple of spots in breakpoint.c. This patch removes it in favor of just writing it out at the spots where it was used. Diff: --- gdb/breakpoint.c | 4 ++-- gdb/utils.c | 6 ------ gdb/utils.h | 2 -- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 54775000919..30d438d06df 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -3138,7 +3138,7 @@ update_inserted_breakpoint_locations (void) if (error_flag) { target_terminal::ours_for_output (); - error_stream (tmp_error_stream); + error (("%s"), tmp_error_stream.c_str ()); } } @@ -3235,7 +3235,7 @@ insert_breakpoint_locations (void) You may have requested too many hardware breakpoints/watchpoints.\n"); } target_terminal::ours_for_output (); - error_stream (tmp_error_stream); + error (("%s"), tmp_error_stream.c_str ()); } } diff --git a/gdb/utils.c b/gdb/utils.c index 3cd2287a52e..3af54ec5179 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -166,12 +166,6 @@ verror (const char *string, va_list args) throw_verror (GENERIC_ERROR, string, args); } -void -error_stream (const string_file &stream) -{ - error (("%s"), stream.c_str ()); -} - /* Emit a message and abort. */ static void ATTRIBUTE_NORETURN diff --git a/gdb/utils.h b/gdb/utils.h index 29ff376bb52..2d831bac184 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -285,8 +285,6 @@ extern void (*deprecated_error_begin_hook) (void); extern const char *warning_pre_print; -extern void error_stream (const string_file &) ATTRIBUTE_NORETURN; - extern void demangler_vwarning (const char *file, int line, const char *, va_list ap) ATTRIBUTE_PRINTF (3, 0);
reply other threads:[~2023-05-02 15:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230502152909.BC501385802F@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).