From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 69D06389850D; Fri, 12 May 2023 09:43:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69D06389850D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683884632; bh=8jdtXxJvDMFdCVrrvw1gJcS2nFBmbg5IUIQXF1wytig=; h=From:To:Subject:Date:From; b=bs4LKSSxSPk9YTEjFplZTQhMsOkwsR63pYLr10uBnc6uItrwL0hjg/xIzuzQPLsXV o8jCseO3YIWOYA1dZi/rNq3vfJeh2UGL3nu1dfNvbtuJKt3hfxdK9WoW76hcXU3nzG oKP0FZTYlliWcK/1d60Nhd2nAbfgccVoMiSD3O0Q= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Make is_64_target more robust X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: f0f6df0a04fe521ff4df9b74981a624fa2583e3a X-Git-Newrev: 388f63c18f523ca32199adef33dbacbeeed3b62a Message-Id: <20230512094352.69D06389850D@sourceware.org> Date: Fri, 12 May 2023 09:43:52 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D388f63c18f52= 3ca32199adef33dbacbeeed3b62a commit 388f63c18f523ca32199adef33dbacbeeed3b62a Author: Tom de Vries Date: Fri May 12 11:43:41 2023 +0200 [gdb/testsuite] Make is_64_target more robust =20 I ran test-case gdb.dwarf2/opt-out-not-implptr.exp with make-check-all.= sh, and with target board dwarf64 ran into: ... FAIL: gdb.dwarf2/opt-out-not-implptr.exp: print noptr ... due to is_target_64 failing because of: ... builtin_spawn -ignore SIGHUP gcc -fno-stack-protector \ -fdiagnostics-color=3Dnever -w -c -gdwarf64 -g -o is_64_target.o \ is_64_target.c^M gcc: error: '-gdwarf64' is ambiguous; use '-gdwarf-64' for DWARF versio= n or \ '-gdwarf -g64' for debug level^M compiler exited with status 1 ... =20 The FAIL is the same FAIL I run into with target board unix/-m32: is_ta= rget_64 fails for both cases. =20 The reason that is_target_64 is failing for target board dwarf64, is be= cause of using system compiler 7.5.0 which doesn't support -gdwarf64. =20 Fix this by making is_target_64 use nodebug instead of debug for compil= ation. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/lib/gdb.exp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 50c10333df1..010da097766 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3492,7 +3492,7 @@ gdb_caching_proc is_lp64_target {} { # This cannot be decided simply from looking at the target string, # as it might depend on externally passed compiler options like -m64. gdb_caching_proc is_64_target {} { - return [gdb_can_simple_compile is_64_target { + return [gdb_can_simple_compile_nodebug is_64_target { int function(void) { return 3; } int dummy[sizeof (&function) =3D=3D 8 ? 1 : -1]; }] @@ -4736,6 +4736,13 @@ proc gdb_can_simple_compile {name code {type object}= {compile_flags ""} {default return $ret } =20 +# As gdb_can_simple_compile, but defaults to using nodebug instead of debu= g. +proc gdb_can_simple_compile_nodebug {name code {type object} {compile_flag= s ""} + {default_compile_flags "nodebug nowarning quiet"}} { + return [gdb_can_simple_compile $name $code $type $compile_flags \ + $default_compile_flags] +} + # Some targets need to always link a special object in. Save its path her= e. global gdb_saved_set_unbuffered_mode_obj set gdb_saved_set_unbuffered_mode_obj ""