public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove some FIXME comments from DAP Date: Mon, 22 May 2023 12:54:44 +0000 (GMT) [thread overview] Message-ID: <20230522125444.701243858D37@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7a8a6f57eced9a8c27a93cb5c5977a33be7b1f72 commit 7a8a6f57eced9a8c27a93cb5c5977a33be7b1f72 Author: Tom Tromey <tromey@adacore.com> Date: Fri May 19 09:24:56 2023 -0600 Remove some FIXME comments from DAP I recently added a 'dap' component to bugzilla, and I filed a few bugs there. This patch removes the corresponding FIXME comments. A few such comments still exist. In at least one case, I have a fix I'll be submitting eventually; in others I think I need to do a bit of investigation to properly file a bug report. Diff: --- gdb/python/lib/gdb/dap/bt.py | 1 - gdb/python/lib/gdb/dap/evaluate.py | 2 -- gdb/python/lib/gdb/dap/events.py | 3 --- gdb/python/lib/gdb/dap/next.py | 1 - 4 files changed, 7 deletions(-) diff --git a/gdb/python/lib/gdb/dap/bt.py b/gdb/python/lib/gdb/dap/bt.py index c5ede6e4c56..21cedb73d26 100644 --- a/gdb/python/lib/gdb/dap/bt.py +++ b/gdb/python/lib/gdb/dap/bt.py @@ -46,7 +46,6 @@ def _backtrace(thread_id, levels, startFrame): set_thread(thread_id) frames = [] current_number = 0 - # FIXME could invoke frame filters here. try: current_frame = gdb.newest_frame() except gdb.error: diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/evaluate.py index 55d41b0806d..05816474688 100644 --- a/gdb/python/lib/gdb/dap/evaluate.py +++ b/gdb/python/lib/gdb/dap/evaluate.py @@ -51,7 +51,6 @@ def _repl(command, frame_id): } -# FIXME 'format' & hex # FIXME supportsVariableType handling @request("evaluate") def eval_request(*, expression, frameId=None, context="variables", **args): @@ -74,7 +73,6 @@ def _variables(ref, start, count): @request("variables") # Note that we ignore the 'filter' field. That seems to be # specific to javascript. -# FIXME: implement format def variables(*, variablesReference, start=0, count=0, **args): result = send_gdb_with_response( lambda: _variables(variablesReference, start, count) diff --git a/gdb/python/lib/gdb/dap/events.py b/gdb/python/lib/gdb/dap/events.py index 5b25470211f..d9ae603dfa4 100644 --- a/gdb/python/lib/gdb/dap/events.py +++ b/gdb/python/lib/gdb/dap/events.py @@ -140,13 +140,10 @@ def _on_stop(event): global _expected_stop obj = { "threadId": gdb.selected_thread().global_num, - # FIXME we don't support non-stop for now. "allThreadsStopped": True, } if isinstance(event, gdb.BreakpointEvent): # Ignore the expected stop, we hit a breakpoint instead. - # FIXME differentiate between 'breakpoint', 'function breakpoint', - # 'data breakpoint' and 'instruction breakpoint' here. _expected_stop = StopKinds.BREAKPOINT obj["hitBreakpointIds"] = [x.number for x in event.breakpoints] elif _expected_stop is None: diff --git a/gdb/python/lib/gdb/dap/next.py b/gdb/python/lib/gdb/dap/next.py index 33898ed6103..636dfce997d 100644 --- a/gdb/python/lib/gdb/dap/next.py +++ b/gdb/python/lib/gdb/dap/next.py @@ -47,5 +47,4 @@ def stepIn(*, threadId, granularity="statement", **args): @request("continue") def continue_request(**args): send_gdb(ExecutionInvoker("continue", None)) - # FIXME Just ignore threadId for the time being, and assume all-stop. return {"allThreadsContinued": True}
reply other threads:[~2023-05-22 12:54 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230522125444.701243858D37@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).