From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 701243858D37; Mon, 22 May 2023 12:54:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 701243858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684760084; bh=A70o4/7Y1825jcFRfkiSHfMmDYT0xDCN5BNwK38QeRs=; h=From:To:Subject:Date:From; b=rLjBYCEBQpMfCN2zxcLKoHQ+bQC8yHN32sYWgF1pqZc5tgERyrjpaM7PC97bp3HOl IhivTF1Xk2lJ31/3kdr9XJxQaFonVpYSVjGemMlF1X2WVgd+cr6Tr1Xz9F8mrGl8bv YtvO31fRSG36WCH5VzXXv2t++e4AhTit2XMtcXjQ= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove some FIXME comments from DAP X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 7b67409b99edca33b76961179286fb43a1714dd2 X-Git-Newrev: 7a8a6f57eced9a8c27a93cb5c5977a33be7b1f72 Message-Id: <20230522125444.701243858D37@sourceware.org> Date: Mon, 22 May 2023 12:54:44 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D7a8a6f57eced= 9a8c27a93cb5c5977a33be7b1f72 commit 7a8a6f57eced9a8c27a93cb5c5977a33be7b1f72 Author: Tom Tromey Date: Fri May 19 09:24:56 2023 -0600 Remove some FIXME comments from DAP =20 I recently added a 'dap' component to bugzilla, and I filed a few bugs there. This patch removes the corresponding FIXME comments. =20 A few such comments still exist. In at least one case, I have a fix I'll be submitting eventually; in others I think I need to do a bit of investigation to properly file a bug report. Diff: --- gdb/python/lib/gdb/dap/bt.py | 1 - gdb/python/lib/gdb/dap/evaluate.py | 2 -- gdb/python/lib/gdb/dap/events.py | 3 --- gdb/python/lib/gdb/dap/next.py | 1 - 4 files changed, 7 deletions(-) diff --git a/gdb/python/lib/gdb/dap/bt.py b/gdb/python/lib/gdb/dap/bt.py index c5ede6e4c56..21cedb73d26 100644 --- a/gdb/python/lib/gdb/dap/bt.py +++ b/gdb/python/lib/gdb/dap/bt.py @@ -46,7 +46,6 @@ def _backtrace(thread_id, levels, startFrame): set_thread(thread_id) frames =3D [] current_number =3D 0 - # FIXME could invoke frame filters here. try: current_frame =3D gdb.newest_frame() except gdb.error: diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/ev= aluate.py index 55d41b0806d..05816474688 100644 --- a/gdb/python/lib/gdb/dap/evaluate.py +++ b/gdb/python/lib/gdb/dap/evaluate.py @@ -51,7 +51,6 @@ def _repl(command, frame_id): } =20 =20 -# FIXME 'format' & hex # FIXME supportsVariableType handling @request("evaluate") def eval_request(*, expression, frameId=3DNone, context=3D"variables", **a= rgs): @@ -74,7 +73,6 @@ def _variables(ref, start, count): @request("variables") # Note that we ignore the 'filter' field. That seems to be # specific to javascript. -# FIXME: implement format def variables(*, variablesReference, start=3D0, count=3D0, **args): result =3D send_gdb_with_response( lambda: _variables(variablesReference, start, count) diff --git a/gdb/python/lib/gdb/dap/events.py b/gdb/python/lib/gdb/dap/even= ts.py index 5b25470211f..d9ae603dfa4 100644 --- a/gdb/python/lib/gdb/dap/events.py +++ b/gdb/python/lib/gdb/dap/events.py @@ -140,13 +140,10 @@ def _on_stop(event): global _expected_stop obj =3D { "threadId": gdb.selected_thread().global_num, - # FIXME we don't support non-stop for now. "allThreadsStopped": True, } if isinstance(event, gdb.BreakpointEvent): # Ignore the expected stop, we hit a breakpoint instead. - # FIXME differentiate between 'breakpoint', 'function breakpoint', - # 'data breakpoint' and 'instruction breakpoint' here. _expected_stop =3D StopKinds.BREAKPOINT obj["hitBreakpointIds"] =3D [x.number for x in event.breakpoints] elif _expected_stop is None: diff --git a/gdb/python/lib/gdb/dap/next.py b/gdb/python/lib/gdb/dap/next.py index 33898ed6103..636dfce997d 100644 --- a/gdb/python/lib/gdb/dap/next.py +++ b/gdb/python/lib/gdb/dap/next.py @@ -47,5 +47,4 @@ def stepIn(*, threadId, granularity=3D"statement", **args= ): @request("continue") def continue_request(**args): send_gdb(ExecutionInvoker("continue", None)) - # FIXME Just ignore threadId for the time being, and assume all-stop. return {"allThreadsContinued": True}