[binutils-gdb] [gdb/testsuite] Fix reverse attribute in tuiterm

[binutils-gdb] [gdb/testsuite] Fix reverse attribute in tuiterm

[Tom de Vries]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7f05c98b812285723c5931bc5cf1a8b5ff903290

commit 7f05c98b812285723c5931bc5cf1a8b5ff903290
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri May 26 12:30:24 2023 +0200

    [gdb/testsuite] Fix reverse attribute in tuiterm
    
    I noticed in proc Term::_csi_m arguments that while parameters 7 and 27 are
    supposed to set the reverse attribute to 1 and 0, in fact it's set to 1 in
    both cases:
    ...
                        7 {
                            set _attrs(reverse) 1
                        }
      ...
                        27 {
                            set _attrs(reverse) 1
                        }
    ...
    
    Fix this and add a regression test in gdb.tui/tuiterm.exp.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.tui/tuiterm.exp | 36 ++++++++++++++++++++++++++++++++++++
 gdb/testsuite/lib/tuiterm.exp     |  2 +-
 2 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.tui/tuiterm.exp b/gdb/testsuite/gdb.tui/tuiterm.exp
index 6cc6c628e73..ff0a3ac48ad 100644
--- a/gdb/testsuite/gdb.tui/tuiterm.exp
+++ b/gdb/testsuite/gdb.tui/tuiterm.exp
@@ -676,6 +676,40 @@ proc test_insert_line { } {
     } 2 0
 }
 
+proc test_attrs {} {
+    foreach { attr vals } {
+	reverse {
+	    7 1
+	    27 0
+	}
+	underline {
+	    4 1
+	    24 0
+	}
+	intensity {
+	    1 bold
+	    2 dim
+	    22 normal
+	}
+    } {
+	setup_terminal 8 1
+	set re ""
+	foreach { arg val } $vals {
+	    Term::_insert "a"
+	    Term::_csi_m $arg
+	    append re "a<$attr:$val>"
+	}
+
+	Term::_insert "a"
+	append re "a"
+
+	set re "^$re *$"
+
+	set line [Term::get_line_with_attrs 0]
+	gdb_assert { [regexp $re $line] } "attribute: $attr"
+    }
+}
+
 # Run proc TEST_PROC_NAME with a "small" terminal.
 
 proc run_one_test_small { test_proc_name } {
@@ -727,3 +761,5 @@ foreach_with_prefix test {
 } {
     run_one_test_large $test
 }
+
+test_attrs
diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp
index 5c0be85ee73..49ce79558c6 100644
--- a/gdb/testsuite/lib/tuiterm.exp
+++ b/gdb/testsuite/lib/tuiterm.exp
@@ -590,7 +590,7 @@ namespace eval Term {
 			set _attrs(underline) 0
 		    }
 		    27 {
-			set _attrs(reverse) 1
+			set _attrs(reverse) 0
 		    }
 		    30 - 31 - 32 - 33 - 34 - 35 - 36 - 37 {
 			set _attrs(fg) $item