public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim: warnings: disable -Wenum-conversion fow now [PR sim/29752]
@ 2023-12-07 13:00 Michael Frysinger
  0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2023-12-07 13:00 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a72924552626025ad0ad032edc7f02ea345fd2b5

commit a72924552626025ad0ad032edc7f02ea345fd2b5
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Wed Dec 6 21:16:17 2023 -0700

    sim: warnings: disable -Wenum-conversion fow now [PR sim/29752]
    
    The cgen code mixes virtual insn enums with insn enums, and there isn't
    an obvious (to me) way to unravel this atm, so disable the warning.
    
    sim/lm32/decode.c:45:5: error:
            implicit conversion from enumeration type 'CGEN_INSN_VIRTUAL_TYPE'
            to different enumeration type 'CGEN_INSN_TYPE' (aka 'enum cgen_insn_type')
            [-Werror,-Wenum-conversion]
       45 |   { VIRTUAL_INSN_X_INVALID, LM32BF_INSN_X_INVALID, LM32BF_SFMT_EMPTY },
          |   ~ ^~~~~~~~~~~~~~~~~~~~~~
    
    Bug: https://sourceware.org/PR29752

Diff:
---
 sim/configure                    | 1 +
 sim/m4/sim_ac_option_warnings.m4 | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/sim/configure b/sim/configure
index 79a21e8be64..7ed9834df39 100755
--- a/sim/configure
+++ b/sim/configure
@@ -15842,6 +15842,7 @@ build_warnings="$build_warnings
 -Wold-style-declaration
 -Wold-style-definition
 -Wpointer-sign
+-Wno-enum-conversion
 "
 
 case "${host}" in
diff --git a/sim/m4/sim_ac_option_warnings.m4 b/sim/m4/sim_ac_option_warnings.m4
index e453d8866ff..52beee86c02 100644
--- a/sim/m4/sim_ac_option_warnings.m4
+++ b/sim/m4/sim_ac_option_warnings.m4
@@ -64,6 +64,9 @@ build_warnings="$build_warnings
 -Wold-style-declaration
 -Wold-style-definition
 -Wpointer-sign
+dnl The cgen virtual insn logic involves enum conversions.
+dnl Disable until we can figure out how to make this work.
+-Wno-enum-conversion
 "
 
 case "${host}" in

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-07 13:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-07 13:00 [binutils-gdb] sim: warnings: disable -Wenum-conversion fow now [PR sim/29752] Michael Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).