[binutils-gdb] gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables

[binutils-gdb] gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables

[Andrew Burgess]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e

commit 1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Wed Nov 22 15:57:56 2023 +0000

    gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables
    
    The gdb/testsuite/README file documents GDB_DEBUG and GDBSERVER_DEBUG
    flags, which can be passed to make in order to enable debugging within
    GDB or gdbserver respectively.
    
    However, when I do:
    
      make check-gdb GDB_DEBUG=infrun
    
    I don't see the corresponding debug feature within GDB being enabled.
    Nor does:
    
      make check-gdb GDBSERVER_DEBUG=debug  \
           RUNTESTFLAGS="--target_board=native-extended-gdbserver"
    
    Appear to enable gdbserver debugging.
    
    I tracked this down to the GDB_DEBUG and GDBSERVER_DEBUG flags being
    missing from the TARGET_FLAGS_TO_PASS variable in gdb/Makefile.  This
    variable already contains lots of testing related flags, like
    RUNTESTFLAGS and TESTS, so I think it makes sense to add GDB_DEBUG and
    GDBSERVER_DEBUG here too.
    
    With this done, this debug feature is now working as expected.
    
    Approved-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/Makefile.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 3510577f090..0886c0e8495 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -993,7 +993,10 @@ TARGET_FLAGS_TO_PASS = \
 	"RUNTEST=$(RUNTEST)" \
 	"RUNTESTFLAGS=$(RUNTESTFLAGS)" \
 	"FORCE_PARALLEL=$(FORCE_PARALLEL)" \
-	"TESTS=$(TESTS)"
+	"TESTS=$(TESTS)" \
+	"GDB_DEBUG=$(GDB_DEBUG)" \
+	"GDBSERVER_DEBUG=$(GDBSERVER_DEBUG)" \
+
 
 # All source files that go into linking GDB.