public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/options: fix copy&paste error in string_option_def
@ 2023-12-14 16:29 Andrew Burgess
0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2023-12-14 16:29 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=03ce4e1bdb8f46742b7bcf648ad4ebd90dbee935
commit 03ce4e1bdb8f46742b7bcf648ad4ebd90dbee935
Author: Andrew Burgess <aburgess@redhat.com>
Date: Thu Dec 14 11:54:13 2023 +0000
gdb/options: fix copy&paste error in string_option_def
Spotted what appears to be a copy&paste error in string_option_def,
the code for string handling writes the address fetching callback
function into the option_def::var_address::enumeration location,
rather than option_def::var_address::string.
Of course, this works just fine as option_def::var_address is a union,
and all of its members are function pointers, so they're going to be
the same size on every target GDB cares about.
But it doesn't hurt to be correct, so fixed in this commit.
There should be no user visible changes after this commit.
Diff:
---
gdb/cli/cli-option.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/cli/cli-option.h b/gdb/cli/cli-option.h
index 4c62227f31c..2645c58188c 100644
--- a/gdb/cli/cli-option.h
+++ b/gdb/cli/cli-option.h
@@ -304,7 +304,7 @@ struct string_option_def : option_def
show_cmd_cb_,
set_doc_, show_doc_, help_doc_)
{
- var_address.enumeration = detail::get_var_address<const char *, Context>;
+ var_address.string = detail::get_var_address<std::string, Context>;
}
};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-14 16:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14 16:29 [binutils-gdb] gdb/options: fix copy&paste error in string_option_def Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).