public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim: arm: fix -Wimplicit-fallthrough warnings
@ 2023-12-21 7:01 Michael Frysinger
0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2023-12-21 7:01 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=beb9aecf1216e8a85a438a03c1b61023b928e596
commit beb9aecf1216e8a85a438a03c1b61023b928e596
Author: Mike Frysinger <vapier@gentoo.org>
Date: Thu Dec 21 01:28:16 2023 -0500
sim: arm: fix -Wimplicit-fallthrough warnings
Replace some fall through comments with the attribute.
Diff:
---
sim/arm/armemu.c | 6 +++---
sim/arm/armos.c | 1 +
sim/arm/thumbemu.c | 7 ++++---
sim/arm/wrapper.c | 4 ++--
4 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/sim/arm/armemu.c b/sim/arm/armemu.c
index ab7454628ba..2b8ae007cb5 100644
--- a/sim/arm/armemu.c
+++ b/sim/arm/armemu.c
@@ -4388,7 +4388,7 @@ check_PMUintr:
ARMul_UndefInstr (state, instr);
break;
}
- /* Drop through. */
+ ATTRIBUTE_FALLTHROUGH;
case 0xc0: /* Store , No WriteBack , Post Dec. */
ARMul_STC (state, instr, LHS);
@@ -4435,7 +4435,7 @@ check_PMUintr:
ARMul_UndefInstr (state, instr);
break;
}
- /* Drop through. */
+ ATTRIBUTE_FALLTHROUGH;
case 0xc1: /* Load , No WriteBack , Post Dec. */
ARMul_LDC (state, instr, LHS);
@@ -4622,7 +4622,7 @@ check_PMUintr:
default:
break;
}
- /* Drop through. */
+ ATTRIBUTE_FALLTHROUGH;
case 0xe0:
case 0xe4:
diff --git a/sim/arm/armos.c b/sim/arm/armos.c
index 374861d7a5e..6deb722d204 100644
--- a/sim/arm/armos.c
+++ b/sim/arm/armos.c
@@ -832,6 +832,7 @@ ARMul_OSHandleSWI (ARMul_State * state, ARMword number)
}
break;
}
+ ATTRIBUTE_FALLTHROUGH;
default:
unhandled = TRUE;
diff --git a/sim/arm/thumbemu.c b/sim/arm/thumbemu.c
index 6915d23ec4c..99f51ef3469 100644
--- a/sim/arm/thumbemu.c
+++ b/sim/arm/thumbemu.c
@@ -308,7 +308,7 @@ handle_T2_insn (ARMul_State * state,
* pvalid = t_branch;
break;
}
- /* Fall through. */
+ ATTRIBUTE_FALLTHROUGH;
case 0x42:
case 0x43:
case 0x47:
@@ -2261,7 +2261,7 @@ ARMul_ThumbDecode (ARMul_State * state,
| ((tinstr & 0x0078) >> 3); /* Rd */
break;
}
- /* Drop through. */
+ ATTRIBUTE_FALLTHROUGH;
default:
case 0x0: /* UNDEFINED */
case 0x4: /* UNDEFINED */
@@ -2415,7 +2415,7 @@ ARMul_ThumbDecode (ARMul_State * state,
* ainstr = 0xE1200070 | ((tinstr & 0xf0) << 4) | (tinstr & 0xf);
break;
}
- /* Drop through. */
+ ATTRIBUTE_FALLTHROUGH;
default:
/* Everything else is an undefined instruction. */
handle_v6_thumb_insn (state, tinstr, next_instr, pc, ainstr, & valid);
@@ -2601,6 +2601,7 @@ ARMul_ThumbDecode (ARMul_State * state,
}
/* else we fall through to process the second half of the BL */
pc += 2; /* point the pc at the 2nd half */
+ ATTRIBUTE_FALLTHROUGH;
case 31: /* BL instruction 2 */
if (state->is_v6)
{
diff --git a/sim/arm/wrapper.c b/sim/arm/wrapper.c
index 52b4dc7d6e0..8d928a6f79f 100644
--- a/sim/arm/wrapper.c
+++ b/sim/arm/wrapper.c
@@ -251,7 +251,7 @@ sim_create_inferior (SIM_DESC sd ATTRIBUTE_UNUSED,
(sim_callback,
"Unknown machine type '%d'; please update sim_create_inferior.\n",
mach);
- /* fall through */
+ ATTRIBUTE_FALLTHROUGH;
case 0:
/* We wouldn't set the machine type with earlier toolchains, so we
@@ -310,7 +310,7 @@ sim_create_inferior (SIM_DESC sd ATTRIBUTE_UNUSED,
ARMul_SelectProcessor (state, ARM_v5_Prop | ARM_v5e_Prop | ARM_XScale_Prop);
break;
}
- /* Otherwise drop through. */
+ ATTRIBUTE_FALLTHROUGH;
case bfd_mach_arm_5T:
ARMul_SelectProcessor (state, ARM_v5_Prop);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-21 7:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 7:01 [binutils-gdb] sim: arm: fix -Wimplicit-fallthrough warnings Michael Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).