public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] sim: sh: fix plds Dz,MACL implementation
Date: Sun, 24 Dec 2023 08:56:30 +0000 (GMT)	[thread overview]
Message-ID: <20231224085631.7FE4E3858C62@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fed277fe1516127a0414eeda0b17a8bb6b318baf

commit fed277fe1516127a0414eeda0b17a8bb6b318baf
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Sun Dec 24 03:53:03 2023 -0500

    sim: sh: fix plds Dz,MACL implementation
    
    The plds Dz,MACL insn stores the Dz bit into MACL.  The current code
    was storing the "res" variable into Dz and then into MACL, but not
    setting "res" to anything.  Delete that logic and make it match the
    existing plds Dz,MACH insn.

Diff:
---
 sim/sh/gencode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c
index 9683dc46b86..8ef3f3e3376 100644
--- a/sim/sh/gencode.c
+++ b/sim/sh/gencode.c
@@ -2439,7 +2439,7 @@ static op ppi_tab[] =
     "if (0xa05f >> z & 1)",
     "  RAISE_EXCEPTION (SIGILL);",
     "else",
-    "  MACL = DSP_R (z) = res;",
+    "  MACL = DSP_R (z);",
     "return;",
   },
   /* sh4a */

                 reply	other threads:[~2023-12-24  8:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231224085631.7FE4E3858C62@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).