public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: don't set frame id after calling cooked_read_value
@ 2023-12-24 18:27 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2023-12-24 18:27 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6658f874cf7b521bf2ce431fcf31cc89aebc7009

commit 6658f874cf7b521bf2ce431fcf31cc89aebc7009
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed Dec 20 18:18:47 2023 +0000

    gdb: don't set frame id after calling cooked_read_value
    
    I don't think that setting the next frame id is needed there, all code
    paths in cooked_read_value do set it properly, AFAIK.
    
    Change-Id: Idb9d9e6f89c2c95c5ebfeec2a63fde89ed84cf3d

Diff:
---
 gdb/sentinel-frame.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/sentinel-frame.c b/gdb/sentinel-frame.c
index 3e5b9be2edf..9a9e4c29198 100644
--- a/gdb/sentinel-frame.c
+++ b/gdb/sentinel-frame.c
@@ -54,7 +54,6 @@ sentinel_frame_prev_register (frame_info_ptr this_frame,
   gdb_assert (is_sentinel_frame_id (this_frame_id));
 
   value = cache->regcache->cooked_read_value (regnum);
-  VALUE_NEXT_FRAME_ID (value) = this_frame_id;
 
   return value;
 }

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-12-24 18:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-24 18:27 [binutils-gdb] gdb: don't set frame id after calling cooked_read_value Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).