[binutils-gdb] [gdb/testsuite] Fix tcl error in gdb.dap/sources.exp

[Tom de Vries <vries@sourceware.org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda

commit 4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 13 10:44:25 2024 +0100

    [gdb/testsuite] Fix tcl error in gdb.dap/sources.exp
    
    With test-case gdb.dap/sources.exp, I run into:
    ...
    {"request_seq": 4, "type": "response", "command": "source", \
      "success": false, "message": "notStopped", \
      "seq": 11}FAIL: gdb.dap/sources.exp: get source success
    ERROR: tcl error sourcing gdb.dap/sources.exp.
    ERROR: key "body" not known in dictionary
    ...
    
    The FAIL has been filed as PR dap/31374.
    
    The ERROR happens because after the FAIL, dap_check_request_and_response
    returns "", and the test-case doesn't check for that.
    
    Fix this by checking for $obj != "" in the test-case.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.dap/sources.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dap/sources.exp b/gdb/testsuite/gdb.dap/sources.exp
index b60681160af..f601190d6f5 100644
--- a/gdb/testsuite/gdb.dap/sources.exp
+++ b/gdb/testsuite/gdb.dap/sources.exp
@@ -49,8 +49,10 @@ if {$path == ""} {
     set obj [dap_check_request_and_response "get source" source \
 		 [format {o source [o path [s %s]] \
 			    sourceReference [i 0]} $path]]
-    set text [dict get [lindex $obj 0] body content]
-    gdb_assert {[string first "Distinguishing comment" $text] != -1}
+    if { $obj != "" } {
+	set text [dict get [lindex $obj 0] body content]
+	gdb_assert {[string first "Distinguishing comment" $text] != -1}
+    }
 }