public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Shahab Vahedi <shahab@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] arc: Don't build arc-analyze-prologue.S with -g
Date: Tue, 27 Feb 2024 14:10:37 +0000 (GMT)	[thread overview]
Message-ID: <20240227141037.0E56B3858C78@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5998b4a287772756e33d311a570df080a4f6e051

commit 5998b4a287772756e33d311a570df080a4f6e051
Author: Yuriy Kolerov <kolerov93@gmail.com>
Date:   Thu Feb 22 08:02:19 2024 +0000

    arc: Don't build arc-analyze-prologue.S with -g
    
    arc-analyze-prologue.S test does not contain debug information thus
    it must be compiled without -g option. Otherwise GDB will try to
    unwind frames using debug information (which does not exist for .S
    code!) instead of analyzing frames manually.
    
    Approved-By: Shahab Vahedi <shahab@synopsys.com>

Diff:
---
 gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
index 32387c00169..b8d9a8fb75f 100644
--- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
+++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
@@ -19,7 +19,13 @@ require {istarget "arc*-*-*"}
 
 standard_testfile .S
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
+# arc-analyze-prologue.S test does not contain debug information thus it must
+# be compiled without -g option. Otherwise GDB will try to unwind frames using
+# debug information (which does not exist for .S code!) instead of analyzing
+# frames manually.
+set options {}
+
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile $options] } {
     return -1
 }

                 reply	other threads:[~2024-02-27 14:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240227141037.0E56B3858C78@sourceware.org \
    --to=shahab@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).