public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Use the .py file in gdb.dap/pause.exp
Date: Tue, 27 Feb 2024 16:56:44 +0000 (GMT)	[thread overview]
Message-ID: <20240227165645.01D2F3858402@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cfe51255b892962c25166cc0afd8911caf9e1e56

commit cfe51255b892962c25166cc0afd8911caf9e1e56
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Feb 16 10:39:46 2024 -0700

    Use the .py file in gdb.dap/pause.exp
    
    Tom de Vries pointed out that the gdb.dap/pause.exp test writes a
    Python file but then does not use it.  This patch corrects the
    oversight.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354
    Reviewed-By: Tom de Vries <tdevries@suse.de>

Diff:
---
 gdb/testsuite/gdb.dap/pause.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.dap/pause.exp b/gdb/testsuite/gdb.dap/pause.exp
index 4d13dadd3ad..9038d0f037f 100644
--- a/gdb/testsuite/gdb.dap/pause.exp
+++ b/gdb/testsuite/gdb.dap/pause.exp
@@ -134,7 +134,7 @@ dap_read_response cancel $cancel_id
 # does not continue the inferior) can be canceled.
 #
 
-write_file py "while True:\n  pass"
+set gdbfile [write_file py "while True:\n  pass"]
 set cont_id [dap_send_request evaluate \
 		 [format {o expression [s "source %s"] context [s repl]} \
 		      $gdbfile]]

                 reply	other threads:[~2024-02-27 16:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240227165645.01D2F3858402@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).