public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix reinterpret_cast for classes with multiple inheritance Date: Wed, 20 Mar 2024 17:02:53 +0000 (GMT) [thread overview] Message-ID: <20240320170253.103AA385828C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=23cdd9431ad424b092c65419d47ef4601168a1c9 commit 23cdd9431ad424b092c65419d47ef4601168a1c9 Author: Hannes Domani <ssbssa@yahoo.de> Date: Wed Mar 20 18:02:06 2024 +0100 Fix reinterpret_cast for classes with multiple inheritance Currently a reinterpret_cast may change the pointer value if multiple inheritance is involved: ``` (gdb) p r $1 = (Right *) 0x22f75c (gdb) p reinterpret_cast<LeftRight*>(r) $2 = (LeftRight *) 0x22f758 ``` It's because value_cast is called in this case, which automatically does up- and downcasting. Fixed by simply using the target pointer type in a copy of the original value: ``` (gdb) p r $1 = (Right *) 0x3bf87c (gdb) p reinterpret_cast<LeftRight*>(r) $2 = (LeftRight *) 0x3bf87c ``` Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18861 Approved-By: Tom Tromey <tom@tromey.com> Diff: --- gdb/testsuite/gdb.cp/casts.cc | 8 ++++++++ gdb/testsuite/gdb.cp/casts.exp | 10 ++++++++++ gdb/valops.c | 11 +++++++++-- 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.cp/casts.cc b/gdb/testsuite/gdb.cp/casts.cc index 5c7f9dc8a1c..eacd8bc0a44 100644 --- a/gdb/testsuite/gdb.cp/casts.cc +++ b/gdb/testsuite/gdb.cp/casts.cc @@ -88,6 +88,14 @@ main (int argc, char **argv) unsigned long long gd_value = (unsigned long long) (std::uintptr_t)&gd; unsigned long long r_value = (unsigned long long) (Right *) &gd; + LeftRight *lr = &gd; + Left *l = lr; + Right *r = lr; + LeftRight *lr_l = reinterpret_cast<LeftRight *>(l); + LeftRight *lr_r = reinterpret_cast<LeftRight *>(r); + Left *l_lr = reinterpret_cast<Left *>(lr); + Right *r_lr = reinterpret_cast<Right *>(lr); + VirtualLeftRight *vlr = new VirtualLeftRight (); VirtualLeft *vl = vlr; VirtualRight *vr = vlr; diff --git a/gdb/testsuite/gdb.cp/casts.exp b/gdb/testsuite/gdb.cp/casts.exp index 7bfc93b1a02..ca82ab084b9 100644 --- a/gdb/testsuite/gdb.cp/casts.exp +++ b/gdb/testsuite/gdb.cp/casts.exp @@ -180,6 +180,16 @@ gdb_test "print (unsigned long long) (LeftRight *) (Right *) &gd == gd_value" \ gdb_test "print (unsigned long long) (LeftRight *) (Right *) r_value == gd_value" \ " = true" +gdb_test "print reinterpret_cast<LeftRight *>(l) == lr_l" " = true" +gdb_test "print reinterpret_cast<LeftRight *>(r) == lr_r" " = true" +gdb_test "print reinterpret_cast<Left *>(lr) == l_lr" " = true" +gdb_test "print reinterpret_cast<Right *>(lr) == r_lr" " = true" + +gdb_test "print &reinterpret_cast<LeftRight &>(*l) == lr_l" " = true" +gdb_test "print &reinterpret_cast<LeftRight &>(*r) == lr_r" " = true" +gdb_test "print &reinterpret_cast<Left &>(*lr) == l_lr" " = true" +gdb_test "print &reinterpret_cast<Right &>(*lr) == r_lr" " = true" + gdb_test "print dynamic_cast<VirtualLeftRight *> (vlr) == vlr" " = true" gdb_test "print dynamic_cast<VirtualLeftRight *> (vl) == vlr" " = true" gdb_test "print dynamic_cast<VirtualLeftRight *> (vr) == vlr" " = true" diff --git a/gdb/valops.c b/gdb/valops.c index be907440a59..1a943f0fc78 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -694,10 +694,17 @@ value_reinterpret_cast (struct type *type, struct value *arg) || (dest_code == TYPE_CODE_MEMBERPTR && arg_code == TYPE_CODE_INT) || (dest_code == TYPE_CODE_INT && arg_code == TYPE_CODE_MEMBERPTR) || (dest_code == arg_code - && (dest_code == TYPE_CODE_PTR - || dest_code == TYPE_CODE_METHODPTR + && (dest_code == TYPE_CODE_METHODPTR || dest_code == TYPE_CODE_MEMBERPTR))) result = value_cast (dest_type, arg); + else if (dest_code == TYPE_CODE_PTR && arg_code == TYPE_CODE_PTR) + { + /* Don't do any up- or downcasting. */ + result = arg->copy (); + result->deprecated_set_type (dest_type); + result->set_enclosing_type (dest_type); + result->set_pointed_to_offset (0); + } else error (_("Invalid reinterpret_cast"));
reply other threads:[~2024-03-20 17:02 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240320170253.103AA385828C@sourceware.org \ --to=ssbssa@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).