From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 270ED3858CDA; Tue, 26 Mar 2024 16:32:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 270ED3858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711470735; bh=tPK+CxxawkWsSgvZPjNWB81V5BegyU4EfkAtZiSTV2s=; h=From:To:Subject:Date:From; b=BKeBMNp0X3Ku3aT9iWTzdmgtvJOM7+P2D2Z7es9dbwJw+uLT7KFaQrSWmKMX7wbPc 6xGQ7pQaSqNlhp5pMlHrRYPnqlrMg07K4vH9krnb7B+D/rWl8F8SZdPtS73JPrCSvQ IWmGhCF3eR9a3meQT/A8kITVUdqEHtWi0HKbqM3w= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix valgrind tests on debian X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 818ef5f4137aaff3afdb52f8bbd3a4c3a9ffa28b X-Git-Newrev: eecab42fb33fcb888fbfdbf457a98a2231fd491e Message-Id: <20240326163215.270ED3858CDA@sourceware.org> Date: Tue, 26 Mar 2024 16:32:15 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Deecab42fb33f= cb888fbfdbf457a98a2231fd491e commit eecab42fb33fcb888fbfdbf457a98a2231fd491e Author: Tom de Vries Date: Tue Mar 26 17:32:09 2024 +0100 [gdb/testsuite] Fix valgrind tests on debian =20 On debian 12, I run into: ... (gdb) target remote | vgdb --wait=3D2 --max-invoke-ms=3D2500 --pid=3D61= 8591^M Remote debugging using | vgdb --wait=3D2 --max-invoke-ms=3D2500 --pid= =3D618591^M relaying data between gdb and process 618591^M warning: remote target does not support file transfer, \ attempting to access files from local filesystem.^M Reading symbols from /lib/ld-linux-aarch64.so.1...^M (No debugging symbols found in /lib/ld-linux-aarch64.so.1)^M 0x000000000401a980 in ?? () from /lib/ld-linux-aarch64.so.1^M (gdb) FAIL: gdb.base/valgrind-infcall.exp: target remote for vgdb ... =20 The problem is that we're expecting to match either of these regexps: ... set start_re1 " in \\.?_start " set start_re2 "\\.?_start \\(\\) at " ... but there are no dwarf or elf symbols present. =20 Fix this by also allowing: ... set start_re3 "$::hex in \\?\\? \\(\\) from " ... =20 Tested on aarch64-linux. =20 Approved-By: Tom Tromey Diff: --- gdb/testsuite/lib/valgrind.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/valgrind.exp b/gdb/testsuite/lib/valgrind.exp index 2f2d58844f4..c952e929bae 100644 --- a/gdb/testsuite/lib/valgrind.exp +++ b/gdb/testsuite/lib/valgrind.exp @@ -94,7 +94,8 @@ proc vgdb_start { {active_at_startup 1} } { if { $active_at_startup } { set start_re1 " in \\.?_start " set start_re2 "\\.?_start \\(\\) at " - gdb_test "$vgdbcmd" "($start_re1|$start_re2).*" \ + set start_re3 "$::hex in \\?\\? \\(\\) from " + gdb_test "$vgdbcmd" "($start_re1|$start_re2|$start_re3).*" \ "target remote for vgdb" } else { # Let $binfile run a bit before attaching. This is a bit of a hack,