From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id EF3EA3858417; Tue, 26 Mar 2024 18:58:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF3EA3858417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711479528; bh=ABrJrnonSbQVHGyJNAUEJtknFLvHDo2vro43gKKypaY=; h=From:To:Subject:Date:From; b=KOr+Ss4dq8V8bOtyIOsXqtup447vy4+VB5VBlL1DfD/FcL4OwLbxId5QTSNQWI1pV M6QjEm5lHWse++5nulVvJT7k56/pio48ApS+KSwtwdGFvRkOO91RhJkcguw//WreJG SVvHw6ZfBuEjyVq6GeScxPhBcL7U9hVIeWLD2da8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Revert "gdb: fix possible uninitialised variable use" X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: 4c48ff3e92ab45de7b8bb9de30fcc6d70669e2ab X-Git-Newrev: c17389078ae2a2a4f6aade6bfbabbf3a41d28f14 Message-Id: <20240326185848.EF3EA3858417@sourceware.org> Date: Tue, 26 Mar 2024 18:58:48 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc17389078ae2= a2a4f6aade6bfbabbf3a41d28f14 commit c17389078ae2a2a4f6aade6bfbabbf3a41d28f14 Author: Andrew Burgess Date: Tue Mar 26 18:50:58 2024 +0000 Revert "gdb: fix possible uninitialised variable use" =20 This reverts commit 24df37a10f8773ad5db07dc000f694d6405e3a36. Diff: --- gdb/i386-linux-tdep.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 2e84384306d..ed1442236e8 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -700,15 +700,17 @@ i386_linux_core_read_description (struct gdbarch *gdb= arch, x86_xsave_layout layout; uint64_t xcr0 =3D i386_linux_core_read_xsave_info (abfd, layout); =20 - if (xcr0 =3D=3D 0) - { - if (bfd_get_section_by_name (abfd, ".reg-xfp") !=3D nullptr) - xcr0 =3D X86_XSTATE_SSE_MASK; - else - xcr0 =3D X86_XSTATE_X87_MASK; - } + const struct target_desc *tdesc; + if (xcr0 !=3D 0) + tdesc =3D i386_linux_read_description (xcr0); =20 - return i386_linux_read_description (xcr0); + if (tdesc !=3D NULL) + return tdesc; + + if (bfd_get_section_by_name (abfd, ".reg-xfp") !=3D NULL) + return i386_linux_read_description (X86_XSTATE_SSE_MASK); + else + return i386_linux_read_description (X86_XSTATE_X87_MASK); } =20 /* Similar to i386_supply_fpregset, but use XSAVE extended state. */