public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Revert "gdb/arch: assert that X86_XSTATE_MPX is not set for x32"
Date: Tue, 26 Mar 2024 18:59:09 +0000 (GMT)	[thread overview]
Message-ID: <20240326185909.640383858414@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0991b56074af7e6b106015c67925fdcfe039f077

commit 0991b56074af7e6b106015c67925fdcfe039f077
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Mar 26 18:52:36 2024 +0000

    Revert "gdb/arch: assert that X86_XSTATE_MPX is not set for x32"
    
    This reverts commit efba976d9713a92b4507ccfef2257e4589da2798.

Diff:
---
 gdb/arch/amd64.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c
index f182e686dda..b8ff4270079 100644
--- a/gdb/arch/amd64.c
+++ b/gdb/arch/amd64.c
@@ -66,12 +66,8 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux,
   if (xcr0 & X86_XSTATE_AVX)
     regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum);
 
-  if (xcr0 & X86_XSTATE_MPX)
-    {
-      /* MPX is not available on x32.  */
-      gdb_assert (!is_x32);
-      regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum);
-    }
+  if ((xcr0 & X86_XSTATE_MPX) && !is_x32)
+    regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum);
 
   if (xcr0 & X86_XSTATE_AVX512)
     regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum);

                 reply	other threads:[~2024-03-26 18:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326185909.640383858414@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).