From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id AE233385842C; Mon, 8 Apr 2024 09:27:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE233385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712568439; bh=plnD5OSu/ECgYrbNS3PK1o5Y/DWy3y8x187djCSkVsQ=; h=From:To:Subject:Date:From; b=ZU11wptcyogpMM+XklMf5AWBrb3eCtz3L1IXx5Tr+ZcL5sBCPRL6nvn2hWVCYB40u qttp4Ui5brsG25CRX5if5pFbZVXwM1LjpYJChC86FUy7BemnziIeSqm8IPcgeMhGaK Y0mc0N1Lhes7aw3QPu4sd7ig07Tt3BcLsRMUBRxI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/configure: use AC_MSG_NOTICE not a direct echo call X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: b6a12c14513f1c46a74a78eebe0e57a7e3c93846 X-Git-Newrev: ff69d6e9af3bb04cd484f48661d5e47ea366b2d5 Message-Id: <20240408092719.AE233385842C@sourceware.org> Date: Mon, 8 Apr 2024 09:27:19 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dff69d6e9af3b= b04cd484f48661d5e47ea366b2d5 commit ff69d6e9af3bb04cd484f48661d5e47ea366b2d5 Author: Andrew Burgess Date: Sat Apr 6 16:39:34 2024 +0100 gdb/configure: use AC_MSG_NOTICE not a direct echo call =20 After the recent commits, I noticed that GDB's configure script would still emit two lines even when run in silent mode. If you touch gdb/Makefile.in and then run 'make all' in the gdb/ build directory you'll see this: =20 GEN config.status enable_sim =3D no enableval =3D no =20 Obviously the 'no' might be 'yes' depending on how you actually configured GDB. =20 This is caused by two direct invocations of 'echo' in GDB's configure.ac script. =20 In this commit I replace these calls with use of AC_MSG_NOTICE instead. Now when configure is run with the --silent command line option these lines will not be printed. =20 There should be no changes in the built GDB after this commit. =20 Approved-By: Simon Marchi Diff: --- gdb/configure | 6 ++++-- gdb/configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/configure b/gdb/configure index d0fd1760b88..ffbc14493e2 100755 --- a/gdb/configure +++ b/gdb/configure @@ -32848,8 +32848,10 @@ fi # # Check whether --enable-sim was given. if test "${enable_sim+set}" =3D set; then : - enableval=3D$enable_sim; echo "enable_sim =3D $enable_sim"; - echo "enableval =3D ${enableval}"; + enableval=3D$enable_sim; { $as_echo "$as_me:${as_lineno-$LINENO}: enable= _sim =3D $enable_sim" >&5 +$as_echo "$as_me: enable_sim =3D $enable_sim" >&6;}; + { $as_echo "$as_me:${as_lineno-$LINENO}: enableval =3D ${enableval}" >&5 +$as_echo "$as_me: enableval =3D ${enableval}" >&6;}; case "${enableval}" in yes) ignore_sim=3Dfalse ;; no) ignore_sim=3Dtrue ;; diff --git a/gdb/configure.ac b/gdb/configure.ac index aa91bfb3a17..28e750b6b43 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -2032,8 +2032,8 @@ AC_PATH_X # AC_ARG_ENABLE(sim, AS_HELP_STRING([--enable-sim], [link gdb with simulator]), -[echo "enable_sim =3D $enable_sim"; - echo "enableval =3D ${enableval}"; +[AC_MSG_NOTICE([enable_sim =3D $enable_sim]); + AC_MSG_NOTICE([enableval =3D ${enableval}]); case "${enableval}" in yes) ignore_sim=3Dfalse ;; no) ignore_sim=3Dtrue ;;