From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1551) id 7F8F7384AB4D; Fri, 26 Apr 2024 20:24:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F8F7384AB4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1714163056; bh=rpu4YKOxvIL3JL2dRMYnGEpOB3gjSjcapbtif8yhjQQ=; h=From:To:Subject:Date:From; b=TkviW6l0kL7i5B5OOrP4ZbseWUD60B55W7DXgDzvxaCLgKvKrT5qVAvcaBeZ6a0pd NCZ3OFKoZkeEquUZ8ObUvULDWmtqZTN+fl1/WYoPhJ9AlMGBu42FH7wljtR83ROsdY 7jRNjL2NDCgR0mnWCmitJWgS7sqtv0XmjDvmB79M= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pedro Alves To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdbserver: Fix vAttach response when attaching is not supported X-Act-Checkin: binutils-gdb X-Git-Author: Pedro Alves X-Git-Refname: refs/heads/master X-Git-Oldrev: f1fc8dc2dccb4a224cdd1c3973c7a09a752aa95b X-Git-Newrev: ef27d39dd2c2e7b6af70884895e6d751872ae305 Message-Id: <20240426202416.7F8F7384AB4D@sourceware.org> Date: Fri, 26 Apr 2024 20:24:16 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Def27d39dd2c2= e7b6af70884895e6d751872ae305 commit ef27d39dd2c2e7b6af70884895e6d751872ae305 Author: Pedro Alves Date: Fri Apr 19 14:37:56 2024 +0100 gdbserver: Fix vAttach response when attaching is not supported =20 handle_v_attach calls attach_inferior, which says: =20 "return -1 if attaching is unsupported, 0 if it succeeded, and call error() otherwise." =20 So if attach_inferior return !=3D 0, we have the unsupported case, meaning we should return the empty packet instead of an error. =20 In practice, this shouldn't trigger, as vAttach support is supposed to be reported via qSupported. But it doesn't hurt to be pedantic here. =20 Change-Id: I99cce6fa678f2370571e6bca0657451300956127 Approved-By: Tom Tromey Diff: --- gdbserver/server.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 2633df08ddb..789af36d9a4 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -3318,7 +3318,10 @@ handle_v_attach (char *own_buf) prepare_resume_reply (own_buf, cs.last_ptid, cs.last_status); } else - write_enn (own_buf); + { + /* Not supported. */ + own_buf[0] =3D 0; + } } catch (const gdb_exception_error &exception) {