public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/build] Fix gdbserver/linux-aarch64-low.cc build
Date: Fri,  3 May 2024 13:17:19 +0000 (GMT)	[thread overview]
Message-ID: <20240503131719.75E79384AB58@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=67fe874896e575f8f9fd510e73d080cd3281814c

commit 67fe874896e575f8f9fd510e73d080cd3281814c
Author: Mark Wielaard <mark@klomp.org>
Date:   Fri May 3 15:17:42 2024 +0200

    [gdb/build] Fix gdbserver/linux-aarch64-low.cc build
    
    Commit 0ee25f97d21e ("Fix regression on aarch64-linux gdbserver")
    removed the last use of i in gdbserver/linux-aarch64-low.cc
    (aarch64_target::low_stopped_data_address). Breaking the build on
    aarch64 with:
    
    gdbserver/linux-aarch64-low.cc: In member function ?virtual CORE_ADDR aarch64_target::low_stopped_data_address()?:
    gdbserver/linux-aarch64-low.cc:557:12: error: unused variable ?i? [-Werror=unused-variable]
      557 |   int pid, i;
          |            ^
    cc1plus: all warnings being treated as errors
    
    Fix this by removing the variable i completely.
    
    Fixes: 0ee25f97d21e ("Fix regression on aarch64-linux gdbserver")

Diff:
---
 gdbserver/linux-aarch64-low.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc
index da5c1fd0629..eb30c31f8f8 100644
--- a/gdbserver/linux-aarch64-low.cc
+++ b/gdbserver/linux-aarch64-low.cc
@@ -554,7 +554,7 @@ CORE_ADDR
 aarch64_target::low_stopped_data_address ()
 {
   siginfo_t siginfo;
-  int pid, i;
+  int pid;
   struct aarch64_debug_reg_state *state;
 
   pid = lwpid_of (current_thread);

                 reply	other threads:[~2024-05-03 13:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503131719.75E79384AB58@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).