From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 5E6503849AE8; Tue, 7 May 2024 16:07:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E6503849AE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1715098032; bh=apj0DFuMAtMox77/U9Y69Y4z23g9nhhuvJrhmq81/5o=; h=From:To:Subject:Date:From; b=R2A28qeIuA/Ao9nZQJ6Job5gCqfnTEr3CCC6EDBgkaqplOenzx2Fk8HrGCxclH2L5 H3ecHoBFZ6a7Mxjccm2poo7w/bFSO+b1jEFxmREWodiP+j2xYfamNB/YnP2nsijs7/ ACEsPwKaKnButfrFUvdfh1abUUheBq7x/fEbEt50= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/arch: assert that X86_XSTATE_MPX is not set for x32 X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: 0c58b372e07fe81d23e4fcf6d6cfee8394e8bce5 X-Git-Newrev: 868883583e7520ff1bd99fcb224d2b33a990edff Message-Id: <20240507160712.5E6503849AE8@sourceware.org> Date: Tue, 7 May 2024 16:07:12 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D868883583e75= 20ff1bd99fcb224d2b33a990edff commit 868883583e7520ff1bd99fcb224d2b33a990edff Author: Andrew Burgess Date: Sat Mar 23 16:17:36 2024 +0000 gdb/arch: assert that X86_XSTATE_MPX is not set for x32 =20 While rebasing this series[1] past this commit: =20 commit 4bb20a6244b7091a9a7a2ae35dfbd7e8db27550a Date: Wed Mar 20 04:13:18 2024 -0700 =20 gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 =20 I worried that there could be other paths that might result in an xcr0 value which has X86_XSTATE_MPX set in x32 mode. As everyone eventually calls amd64_create_target_description to build their target description, I figured we could assert in here that if X86_XSTATE_MPX is set then we should not be an x32 target, this will uncover any other bugs in this area. =20 I'm not currently able to build/run any x32 binaries, so I have no way to test this, but the author of commit 4bb20a6244b7091 did test this series with that assert in place and didn't see any problems. =20 [1] https://inbox.sourceware.org/gdb-patches/cover.1714143669.git.aburg= ess@redhat.com =20 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31511 =20 Approved-By: Felix Willgerodt Diff: --- gdb/arch/amd64.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c index cb9683c6931..94d55d72a4e 100644 --- a/gdb/arch/amd64.c +++ b/gdb/arch/amd64.c @@ -65,8 +65,12 @@ amd64_create_target_description (uint64_t xcr0, bool is_= x32, bool is_linux, if (xcr0 & X86_XSTATE_AVX) regnum =3D create_feature_i386_64bit_avx (tdesc.get (), regnum); =20 - if ((xcr0 & X86_XSTATE_MPX) && !is_x32) - regnum =3D create_feature_i386_64bit_mpx (tdesc.get (), regnum); + if (xcr0 & X86_XSTATE_MPX) + { + /* MPX is not available on x32. */ + gdb_assert (!is_x32); + regnum =3D create_feature_i386_64bit_mpx (tdesc.get (), regnum); + } =20 if (xcr0 & X86_XSTATE_AVX512) regnum =3D create_feature_i386_64bit_avx512 (tdesc.get (), regnum);