public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/python] Note that python 3.6 assumes long long support
@ 2024-06-10 14:51 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2024-06-10 14:51 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a8463c6844cf238684bff035ececf1aaeef6135c

commit a8463c6844cf238684bff035ececf1aaeef6135c
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Jun 10 16:52:06 2024 +0200

    [gdb/python] Note that python 3.6 assumes long long support
    
    Starting with python 3.6, support for platforms without long long support
    has been removed [1].
    
    HAVE_LONG_LONG and PY_LONG_LONG are still defined, but only for compatibility,
    so stop relying on them.
    
    Tested on x86_64-linux.
    
    Approved-By: Tom Tromey <tom@tromey.com>
    
    [1] https://github.com/python/cpython/issues/72148

Diff:
---
 gdb/python/python-internal.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h
index 5132ec15ba6..3c450560b9f 100644
--- a/gdb/python/python-internal.h
+++ b/gdb/python/python-internal.h
@@ -102,13 +102,24 @@
 
 /* Python supplies HAVE_LONG_LONG and some `long long' support when it
    is available.  These defines let us handle the differences more
-   cleanly.  */
-#ifdef HAVE_LONG_LONG
+   cleanly.
+
+   Starting with python 3.6, support for platforms without long long support
+   has been removed [1].  HAVE_LONG_LONG and PY_LONG_LONG are still defined,
+   but only for compatibility, so we no longer rely on them.
+
+   [1] https://github.com/python/cpython/issues/72148.  */
+#if PY_VERSION_HEX >= 0x03060000 || defined (HAVE_LONG_LONG)
 
 #define GDB_PY_LL_ARG "L"
 #define GDB_PY_LLU_ARG "K"
+#if PY_VERSION_HEX >= 0x03060000
+typedef long long gdb_py_longest;
+typedef unsigned long long gdb_py_ulongest;
+#else
 typedef PY_LONG_LONG gdb_py_longest;
 typedef unsigned PY_LONG_LONG gdb_py_ulongest;
+#endif
 #define gdb_py_long_as_ulongest PyLong_AsUnsignedLongLong
 #define gdb_py_long_as_long_and_overflow PyLong_AsLongLongAndOverflow

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-06-10 14:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-10 14:51 [binutils-gdb] [gdb/python] Note that python 3.6 assumes long long support Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).