public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix duplicates in gdb.fortran/huge.exp
Date: Thu, 20 Jun 2024 13:36:50 +0000 (GMT)	[thread overview]
Message-ID: <20240620133650.7AC1F389364F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6c58dad0ef53ff7d780c301464e77bdea038c7ec

commit 6c58dad0ef53ff7d780c301464e77bdea038c7ec
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Jun 20 15:37:48 2024 +0200

    [gdb/testsuite] Fix duplicates in gdb.fortran/huge.exp
    
    With test-case gdb.fortran/huge.exp, on a system without fortran compiler, I
    ran into a number of duplicates:
    ...
    Running /home/vries/gdb/src/gdb/testsuite/gdb.fortran/huge.exp ...
    gdb compile failed, default_target_compile: Can't find gfortran.
    UNTESTED: gdb.fortran/huge.exp: huge.exp
      ...
    gdb compile failed, default_target_compile: Can't find gfortran.
    UNTESTED: gdb.fortran/huge.exp: huge.exp
    DUPLICATE: gdb.fortran/huge.exp: huge.exp
    UNSUPPORTED: gdb.fortran/huge.exp: require failed: expr $compilation_succeeded
    ...
    
    Fix this by wrapping the compile in a with_test_prefix, getting us instead:
    ...
    gdb compile failed, default_target_compile: Can't find gfortran.
    UNTESTED: gdb.fortran/huge.exp: CRASH_GDB=2097152: huge.exp
      ...
    gdb compile failed, default_target_compile: Can't find gfortran.
    UNTESTED: gdb.fortran/huge.exp: CRASH_GDB=16: huge.exp
    UNSUPPORTED: gdb.fortran/huge.exp: require failed: expr $compilation_succeeded
    ...
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.fortran/huge.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/huge.exp b/gdb/testsuite/gdb.fortran/huge.exp
index 8d2158f172b..78c1d521e2a 100644
--- a/gdb/testsuite/gdb.fortran/huge.exp
+++ b/gdb/testsuite/gdb.fortran/huge.exp
@@ -37,8 +37,10 @@ lappend opts f90
 set compilation_succeeded 0
 for { set size [expr $max] } { $size >= $min } { set size [expr $size / 2] } {
     set try_opts [concat $opts [list additional_flags=-DCRASH_GDB=$size]]
-    if { [build_executable $testfile.exp $testfile $srcfile $try_opts] == -1 } {
-	continue
+    with_test_prefix CRASH_GDB=$size {
+	if { [build_executable $testfile.exp $testfile $srcfile $try_opts] == -1 } {
+	    continue
+	}
     }
 
     set compilation_succeeded 1

                 reply	other threads:[~2024-06-20 13:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620133650.7AC1F389364F@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).