public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: George Barrett <bob@bob131.so>
To: gdb-patches@sourceware.org
Cc: George Barrett <bob@bob131.so>
Subject: [PATCH v3 0/3] Guile: add value-{reference,const}-value
Date: Thu, 29 Apr 2021 02:27:15 +1000	[thread overview]
Message-ID: <&e1lx8mojs1b03hu3o_asydo0za8-nyh&337akgbzjn.o13/-otj@mail.bob131.so> (raw)

A couple of simple patches implementing functions missing from the
Guile API (relative to the Python API). Both are straight-forward
translations of the Python implementations.

Feedback on the original series pointed out that the Python API also
has a Value.rvalue_reference_value() method and that a matching
Guile procedure should be introduced alongside value-reference-value,
owing to their similarity. This v2 series updates the patch as
indicated; an additional patch improving the Guile support for rvalue
reference types is included to allow for writing an appropriate test.

Feedback on the v2 series pointed out mistaken quoting in the texinfo
manual diff and suggested that API changes be listed in the NEWS
file. This series includes improvements as suggested.

George Barrett (3):
  Guile: improved rvalue reference support
  Guile: add {r,}value-reference-value
  Guile: add value-const-value

 gdb/NEWS                              | 11 +++++
 gdb/doc/guile.texi                    | 18 ++++++++
 gdb/guile/scm-type.c                  |  1 +
 gdb/guile/scm-value.c                 | 66 +++++++++++++++++++++++++++
 gdb/testsuite/gdb.guile/scm-value.exp | 13 ++++++
 5 files changed, 109 insertions(+)

-- 
2.30.2

             reply	other threads:[~2021-04-28 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 16:27 George Barrett [this message]
2021-04-28 16:27 ` [PATCH v3 1/3] Guile: improved rvalue reference support George Barrett
2021-04-28 16:38   ` Eli Zaretskii
2021-04-28 16:54   ` Andrew Burgess
2021-04-28 16:27 ` [PATCH v3 2/3] Guile: add {r,}value-reference-value George Barrett
2021-04-28 16:40   ` Eli Zaretskii
2021-04-28 16:59   ` Andrew Burgess
2021-04-28 17:11     ` George Barrett
2021-04-28 16:27 ` [PATCH v3 3/3] Guile: add value-const-value George Barrett
2021-04-28 16:39   ` Eli Zaretskii
2021-04-28 17:00   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='&e1lx8mojs1b03hu3o_asydo0za8-nyh&337akgbzjn.o13/-otj@mail.bob131.so' \
    --to=bob@bob131.so \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).