From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18751 invoked by alias); 26 Jan 2011 10:52:53 -0000 Received: (qmail 18735 invoked by uid 22791); 26 Jan 2011 10:52:51 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Jan 2011 10:52:42 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p0QAqP3r015331 ; Wed, 26 Jan 2011 11:52:25 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [130.79.204.10]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p0QAqO3B059425 ; Wed, 26 Jan 2011 11:52:25 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p0QAqOXh080552 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 26 Jan 2011 11:52:24 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" , References: <1295394141-14863-1-git-send-email-brobecker@adacore.com> <20110121185746.GD2440@adacore.com> In-Reply-To: <20110121185746.GD2440@adacore.com> Subject: RE: [RFA/commit/doco] move handing of "set interactive-mode" to gdb_has_a_terminal Date: Wed, 26 Jan 2011 15:21:00 -0000 Message-ID: <000001cbbd47$1d831a50$58894ef0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00511.txt.bz2 Hi Joel, I think your patch is good, but it has an error: in gdb_has_a_terminal function: + if (interactive_mode != AUTO_BOOLEAN_AUTO) + return interactive_mode = AUTO_BOOLEAN_TRUE; + The current code sets interactive_mode variable to AUTO_BOOLEAN_TRUE, which happens to be zero, and thus the function returns 0... I suppose that the correct code should be: + if (interactive_mode != AUTO_BOOLEAN_AUTO) + return (interactive_mode == AUTO_BOOLEAN_TRUE); + There is also a small error in the ChangeLog: > > (gdb_has_a_terminal): Add handling of the "iteractive-mode" This should have "interactive-mode" instead of "iteractive-mode" Pierre Muller GDB pascal language maintainer