From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Eli Zaretskii'" <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Avoid unlimited height on mingw built GDB's.
Date: Tue, 13 Aug 2013 08:40:00 -0000 [thread overview]
Message-ID: <000001ce9800$c92d8a70$5b889f50$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <83eha3rmm4.fsf@gnu.org>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Eli Zaretskii
> Envoyé : vendredi 9 août 2013 16:00
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Avoid unlimited height on mingw built GDB's.
>
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Date: Thu, 8 Aug 2013 10:35:01 +0200
> >
> > Mingw builds are using windows-termcap.c source
> > to allow compilation despite the fact that there
> > is often no termcap library for mingw.
> > The stub tgetnum function returns -1 unconditionally,
> > this leads to the screen height being set to unlimited
> > in init_page_info function.
> >
> > Before this, lines_per_page was set correctly
> > by the call to rl_get_screen_size.
> >
> > The patch simply avoid checking tgetnum ("li") if
> > the rows parameter was set to a positive value.
>
> Looks good to me, thanks.
Thank you for the approval,
patch committed,
Pierre Muller
next prev parent reply other threads:[~2013-08-13 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <"001c01ce9412$2c438df0$84caa9d0$@muller"@ics-cnrs.unistra.fr>
2013-08-09 13:59 ` Eli Zaretskii
2013-08-13 8:40 ` Pierre Muller [this message]
2013-08-08 8:35 Pierre Muller
2013-08-08 9:18 ` Yao Qi
2013-08-09 14:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ce9800$c92d8a70$5b889f50$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).