From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30519 invoked by alias); 27 Sep 2013 15:23:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30500 invoked by uid 89); 27 Sep 2013 15:23:51 -0000 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2013 15:23:51 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.1 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 7D857141408; Fri, 27 Sep 2013 17:23:47 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 6EEE71411FA; Fri, 27 Sep 2013 17:23:47 +0200 (CEST) Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mr2.u-strasbg.fr (Postfix) with ESMTP id 456C8141409; Fri, 27 Sep 2013 17:23:45 +0200 (CEST) Received: from ms13.u-strasbg.fr (ms13.u-strasbg.fr [130.79.204.113]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r8RFNiVj007570 ; Fri, 27 Sep 2013 17:23:45 +0200 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms13.u-strasbg.fr (Postfix) with ESMTPSA id 5B03F1FD84; Fri, 27 Sep 2013 17:23:43 +0200 (CEST) From: "Pierre Muller" To: "'Tom Tromey'" Cc: "'gdb-patches'" References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <11813.6176527061$1380225854@news.gmane.org> <87fvsqfgbl.fsf@fleche.redhat.com> In-Reply-To: <87fvsqfgbl.fsf@fleche.redhat.com> Subject: RE: [RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar Date: Fri, 27 Sep 2013 15:23:00 -0000 Message-ID: <000001cebb95$8bc7a040$a356e0c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-09/txt/msg00962.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: vendredi 27 septembre 2013 17:14 > =C0=A0: Pierre Muller > Cc=A0: 'gdb-patches' > Objet=A0: Re: [RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> When "set print sevenbit-strings on" > Pierre> is used, all characters above 127 should be displayed as > Pierre> escapes. >=20 > Pierre> This patch does just that. >=20 > Does it fix any test? This helps a lot in reducing the number of failures on mingw hosts for gdb.base/printcmds.exp https://sourceware.org/bugzilla/show_bug.cgi?id=3D15873 Basically it all comes from the fact that by default mingw host GDb have a default charset which allow to print most chars between 128 and 255 numeric value, thus leading to failures when printing ctable1[x] for x in that range. > If so, could you say which one? > If not, please add a test case. As said, its already in printcmds.exp=20 > Do you actually use this setting? I'm curious. I don't but this test does! Pierre PS: The fact that the results are better for executables that have UTF-8 as default charset is an error in my opinion, as no warning is printed for invalid or incomplete sequence chars! But this was in my first by RFC, and I did not yet resubmit it in this series.