From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26702 invoked by alias); 2 Sep 2010 13:12:51 -0000 Received: (qmail 26621 invoked by uid 22791); 2 Sep 2010 13:12:49 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Sep 2010 13:12:36 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o82DCKir051364 ; Thu, 2 Sep 2010 15:12:21 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms8.u-strasbg.fr [IPv6:2001:660:2402:d::17]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o82DCKID068952 ; Thu, 2 Sep 2010 15:12:20 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o82DCJsV079256 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 2 Sep 2010 15:12:19 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100817184407.GC3599@adacore.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> In-Reply-To: Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris Date: Thu, 02 Sep 2010 14:21:00 -0000 Message-ID: <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00086.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Thursday, September 02, 2010 12:22 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: Your INTERMEDIATE_ENCODING patch for Solaris >=20 > Pierre> So here, the c library iconv functions are used, > Pierre> but the default host-charset is set to ASCII which is > Pierre> not handled by that iconv :( >=20 > Tom> I am not sure how this happens with the patch I posted. > Tom> Does this machine define __STDC_ISO_10646__? > Tom> Or did I somehow get the #if logic wrong? >=20 > I didn't see an answer to this. > I still don't understand how this particular build is using iconv and > not the phony iconv. Sorry, after investigation it appears that: __STDC_ISO_10646__ is not in any headers under /usr/include but both HAVE_WCHAR_T and HAVE_BTOWC are defined, so that with you patch PHONY_ICONV macro doesn't get set. Does this answer your question? > Pierre> I do get a default of '"UTF-8" for Open Solaris machines, > Pierre> but I don't know if other systems might also return "646", > Pierre> but not like the "UTF-8" choice. >=20 > AFAIK only Solaris does this. It seems to me that UTF-8 is not > correct, > though -- it may vary by locale. >=20 > Maybe we need to go even further and blacklist Solaris from ever using > iconv :-(. It would help to know the answer to the above. Probably just define PHONY_ICONV if the first set of conditions is not met (by the way, I am not sure the libiconv version test that we added is really pertinent.) Pierre