From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16167 invoked by alias); 16 Sep 2010 21:31:05 -0000 Received: (qmail 16157 invoked by uid 22791); 16 Sep 2010 21:31:03 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Sep 2010 21:30:55 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o8GLUdKL028629 ; Thu, 16 Sep 2010 23:30:39 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms7.u-strasbg.fr [IPv6:2001:660:2402:d::16]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8GLUcA7097293 ; Thu, 16 Sep 2010 23:30:39 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8GLUbpe063736 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 16 Sep 2010 23:30:38 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100817184407.GC3599@adacore.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <002301cb54bc$661506f0$323f14d0$@muller@ics-cnrs.unistra.fr> <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> In-Reply-To: Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris Date: Thu, 16 Sep 2010 22:31:00 -0000 Message-ID: <000601cb55e6$6aedcec0$40c96c40$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00311.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Thursday, September 16, 2010 8:31 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: Your INTERMEDIATE_ENCODING patch for Solaris >=20 > >>>>> "Pierre" =3D=3D Pierre Muller > writes: >=20 > Tom> Great. Here is what I am checking in. >=20 > Pierre> Nice, but I was wondering if the > Pierre> check of libiconv version is still needed. > Pierre> Wasn't it suggested by me? >=20 > According to the comment, versions of libiconv before 0x10D do not > support "wchar_t" as an argument to iconv_open. >=20 > I think you discovered this, but it is hard to remember. Yes, I wrote that in http://sourceware.org/ml/gdb-patches/2010-08/msg00296.html but I now fear that I made an error in my analysis at that time. Rereading my email lets me think that maybe the Sparc did not link to GNU iconv library, but instead tried to use the libc iconv functions. Troubles is that I lost access to that Sparc machine. > Pierre> I think that checking for the existence of > Pierre> _LIBICONV_VERSION macro should be enough, > Pierre> unless you are really sure that older versions > Pierre> do not work. > Pierre> On systems that have an older GNU libiconv > Pierre> version installed, this might disable the use of GNU libiconv > Pierre> without a good reason. >=20 > I think it is better to fail safe: > If this code is disabled, the user gets reduced functionality. > If this code is erroneously enabled, users can't print strings at all. Would it be possible to test an old libiconv on some other platform? Pierre