From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12700 invoked by alias); 30 Apr 2010 15:32:12 -0000 Received: (qmail 12682 invoked by uid 22791); 30 Apr 2010 15:32:11 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 15:32:05 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3UFVqQH043252 ; Fri, 30 Apr 2010 17:31:52 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3UFVpPg042871 ; Fri, 30 Apr 2010 17:31:52 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3UFVpRD039680 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 30 Apr 2010 17:31:51 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: References: <20100430015357.GA2513@sourceware.org> In-Reply-To: Subject: [RFA] was: New ARI warning Fri Apr 30 01:53:57 UTC 2010 Date: Fri, 30 Apr 2010 15:32:00 -0000 Message-ID: <000901cae87a$4450ca80$ccf25f80$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00992.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Friday, April 30, 2010 5:23 PM > =C0=A0: GDB Administrator > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: New ARI warning Fri Apr 30 01:53:57 UTC 2010 >=20 > >>>>> ">" =3D=3D GDB Administrator writes: >=20 > >> gdb/python/py-param.c:39: regression: var_boolean: Replace > var_boolean with add_setshow_boolean_cmd > >> gdb/python/py-param.c:39: { ', var_boolean }, > >> gdb/python/py-param.c:482: regression: var_boolean: Replace > var_boolean with add_setshow_boolean_cmd > >> gdb/python/py-param.c:482: if (parmclass !=3D var_boolean && > parmclass !=3D var_auto_boolean && parmclass !=3D var_uinteger && > parmclass !=3D var_integer && parmclass !=3D var_string && parmclass > !=3D var_string_noescape && parmclass !=3D var_optional_filename && > parmclass !=3D var_filename && parmclass !=3D var_zinteger && > parmclass !=3D var_enum) >=20 >=20 > Pierre, how can we add an exception for these uses? I already looked at this and found they were valid uses, but when I tried first to add the ARI comments, it did not work correctly first. I fixed gdb_ari.sh to handle "if_assignment" as last rule allow proper recognition of the second ARI comment below. Is this patch OK? 2010-04-30 Pierre Muller * python/py-param.c (parm_constants): Avoid ARI warning by adding ARI comment. (parmpy_init): Likewise. Index: src/gdb/python/py-param.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/python/py-param.c,v retrieving revision 1.1 diff -u -p -r1.1 py-param.c --- src/gdb/python/py-param.c 29 Apr 2010 15:45:56 -0000 1.1 +++ src/gdb/python/py-param.c 30 Apr 2010 15:28:09 -0000 @@ -36,7 +36,7 @@ struct parm_constant =20 struct parm_constant parm_constants[] =3D { - { "PARAM_BOOLEAN", var_boolean }, + { "PARAM_BOOLEAN", var_boolean }, /* ARI: var_boolean */ { "PARAM_AUTO_BOOLEAN", var_auto_boolean }, { "PARAM_UINTEGER", var_uinteger }, { "PARAM_INTEGER", var_integer }, @@ -475,7 +475,8 @@ parmpy_init (PyObject *self, PyObject *a return -1; } =20 - if (parmclass !=3D var_boolean && parmclass !=3D var_auto_boolean + if (parmclass !=3D var_boolean /* ARI: var_boolean */ + && parmclass !=3D var_auto_boolean && parmclass !=3D var_uinteger && parmclass !=3D var_integer && parmclass !=3D var_string && parmclass !=3D var_string_noescape && parmclass !=3D var_optional_filename && parmclass !=3D var_filena= me