* New ARI warning Fri Apr 30 01:53:57 UTC 2010 @ 2010-04-30 1:54 GDB Administrator 2010-04-30 15:23 ` Tom Tromey 0 siblings, 1 reply; 4+ messages in thread From: GDB Administrator @ 2010-04-30 1:54 UTC (permalink / raw) To: gdb-patches 1099a1100,1101 > gdb/python/py-param.c:39: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd gdb/python/py-param.c:39: { ', var_boolean }, > gdb/python/py-param.c:482: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd gdb/python/py-param.c:482: if (parmclass != var_boolean && parmclass != var_auto_boolean && parmclass != var_uinteger && parmclass != var_integer && parmclass != var_string && parmclass != var_string_noescape && parmclass != var_optional_filename && parmclass != var_filename && parmclass != var_zinteger && parmclass != var_enum) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Fri Apr 30 01:53:57 UTC 2010 2010-04-30 1:54 New ARI warning Fri Apr 30 01:53:57 UTC 2010 GDB Administrator @ 2010-04-30 15:23 ` Tom Tromey 2010-04-30 15:32 ` [RFA] was: " Pierre Muller 0 siblings, 1 reply; 4+ messages in thread From: Tom Tromey @ 2010-04-30 15:23 UTC (permalink / raw) To: GDB Administrator; +Cc: gdb-patches >>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes: >> gdb/python/py-param.c:39: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd >> gdb/python/py-param.c:39: { ', var_boolean }, >> gdb/python/py-param.c:482: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd >> gdb/python/py-param.c:482: if (parmclass != var_boolean && parmclass != var_auto_boolean && parmclass != var_uinteger && parmclass != var_integer && parmclass != var_string && parmclass != var_string_noescape && parmclass != var_optional_filename && parmclass != var_filename && parmclass != var_zinteger && parmclass != var_enum) Pierre, how can we add an exception for these uses? Tom ^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFA] was: New ARI warning Fri Apr 30 01:53:57 UTC 2010 2010-04-30 15:23 ` Tom Tromey @ 2010-04-30 15:32 ` Pierre Muller 2010-04-30 16:17 ` Tom Tromey 0 siblings, 1 reply; 4+ messages in thread From: Pierre Muller @ 2010-04-30 15:32 UTC (permalink / raw) To: tromey; +Cc: gdb-patches > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoyé : Friday, April 30, 2010 5:23 PM > À : GDB Administrator > Cc : gdb-patches@sourceware.org > Objet : Re: New ARI warning Fri Apr 30 01:53:57 UTC 2010 > > >>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes: > > >> gdb/python/py-param.c:39: regression: var_boolean: Replace > var_boolean with add_setshow_boolean_cmd > >> gdb/python/py-param.c:39: { ', var_boolean }, > >> gdb/python/py-param.c:482: regression: var_boolean: Replace > var_boolean with add_setshow_boolean_cmd > >> gdb/python/py-param.c:482: if (parmclass != var_boolean && > parmclass != var_auto_boolean && parmclass != var_uinteger && > parmclass != var_integer && parmclass != var_string && parmclass > != var_string_noescape && parmclass != var_optional_filename && > parmclass != var_filename && parmclass != var_zinteger && > parmclass != var_enum) > > > Pierre, how can we add an exception for these uses? I already looked at this and found they were valid uses, but when I tried first to add the ARI comments, it did not work correctly first. I fixed gdb_ari.sh to handle "if_assignment" as last rule allow proper recognition of the second ARI comment below. Is this patch OK? 2010-04-30 Pierre Muller <muller@ics.u-strasbg.fr> * python/py-param.c (parm_constants): Avoid ARI warning by adding ARI comment. (parmpy_init): Likewise. Index: src/gdb/python/py-param.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-param.c,v retrieving revision 1.1 diff -u -p -r1.1 py-param.c --- src/gdb/python/py-param.c 29 Apr 2010 15:45:56 -0000 1.1 +++ src/gdb/python/py-param.c 30 Apr 2010 15:28:09 -0000 @@ -36,7 +36,7 @@ struct parm_constant struct parm_constant parm_constants[] = { - { "PARAM_BOOLEAN", var_boolean }, + { "PARAM_BOOLEAN", var_boolean }, /* ARI: var_boolean */ { "PARAM_AUTO_BOOLEAN", var_auto_boolean }, { "PARAM_UINTEGER", var_uinteger }, { "PARAM_INTEGER", var_integer }, @@ -475,7 +475,8 @@ parmpy_init (PyObject *self, PyObject *a return -1; } - if (parmclass != var_boolean && parmclass != var_auto_boolean + if (parmclass != var_boolean /* ARI: var_boolean */ + && parmclass != var_auto_boolean && parmclass != var_uinteger && parmclass != var_integer && parmclass != var_string && parmclass != var_string_noescape && parmclass != var_optional_filename && parmclass != var_filename ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] was: New ARI warning Fri Apr 30 01:53:57 UTC 2010 2010-04-30 15:32 ` [RFA] was: " Pierre Muller @ 2010-04-30 16:17 ` Tom Tromey 0 siblings, 0 replies; 4+ messages in thread From: Tom Tromey @ 2010-04-30 16:17 UTC (permalink / raw) To: Pierre Muller; +Cc: gdb-patches >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: Pierre> Is this patch OK? Pierre> 2010-04-30 Pierre Muller <muller@ics.u-strasbg.fr> Pierre> * python/py-param.c (parm_constants): Avoid ARI warning Pierre> by adding ARI comment. Pierre> (parmpy_init): Likewise. Yes, thanks. Tom ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-30 16:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-04-30 1:54 New ARI warning Fri Apr 30 01:53:57 UTC 2010 GDB Administrator 2010-04-30 15:23 ` Tom Tromey 2010-04-30 15:32 ` [RFA] was: " Pierre Muller 2010-04-30 16:17 ` Tom Tromey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).