From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22691 invoked by alias); 23 Sep 2010 07:19:53 -0000 Received: (qmail 22400 invoked by uid 22791); 23 Sep 2010 07:19:51 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Sep 2010 07:19:46 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o8N7JV7x002171 ; Thu, 23 Sep 2010 09:19:31 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms5.u-strasbg.fr [IPv6:2001:660:2402:d::14]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8N7JU2O062125 ; Thu, 23 Sep 2010 09:19:31 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8N7JTMP046014 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 23 Sep 2010 09:19:30 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> <20078.2261243605$1284672670@news.gmane.org> <001101cb5663$f6011c10$e2035430$@muller@ics-cnrs.unistra.fr> In-Reply-To: Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris Date: Thu, 23 Sep 2010 14:48:00 -0000 Message-ID: <000901cb5aef$afb465b0$0f1d3110$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00402.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Wednesday, September 22, 2010 10:57 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: Your INTERMEDIATE_ENCODING patch for Solaris >=20 > >>>>> "Pierre" =3D=3D Pierre Muller > writes: >=20 > Pierre> I found the libiconv version 1.5 > Pierre> installed it on a x86 Open Solaris machine, > Pierre> modified gdb_wchar.h to use _LIBICONV_VERSION >=3D 0x105 > Pierre> and got an gdb executable linked to libiconv version 1.5, > Pierre> using --with-libiconv-prefix=3D/usr/local/src/test32 > Pierre> (the installation prefix I used for 1.5 libiconv). > Pierre> I tested charset.exp result on that executable, > Pierre> and got a lot of failures: > [...] >=20 > Pierre> But I was wondering if the problem is not coming from the > Pierre> fact that for 1.5 libiconv find_charset_names function > Pierre> directly calls 'iconv -l' (because iconvlist is not present > Pierre> in this version of the library). >=20 > Ouch. >=20 > Pierre> I also downloaded version 1.8 of libiconv, > Pierre> and checked GDB linked to that version: > Pierre> the results of charset.exp are the same as 1.13.1 (2 FAILs) >=20 > Yeah, how about we make x0108 the minimal acceptable version? > It was released in 2002, that seems plenty old to me. >=20 > If you agree, I will make the change. I agree, furthermore HAVE_LIBICONVLIST should always be set in config.h in that case, which avoids the direct call to 'iconv -l'. =20 > Pierre> PS: Support of libc iconv for Solaris could probably be > Pierre> enhanced by a better parsing of 'iconv -l' output... >=20 > I think there isn't much reason to do it, since we're planning to avoid > Solaris iconv completely. If somebody wants to make the effort, > though, > it is fine by me. Not sure I will have time for that... Pierre