public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Greta Yorsh" <Greta.Yorsh@arm.com>
To: <gdb-patches@sourceware.org>
Cc: "Richard Earnshaw" <Richard.Earnshaw@arm.com>
Subject: [patch][testsuite,arm] Fix .global directives in gdb.arch/arm-disp-step.S
Date: Mon, 18 Jun 2012 15:32:00 -0000	[thread overview]
Message-ID: <000901cd4d67$aa3654b0$fea2fe10$@Yorsh@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

The test gdb.arch/arm-disp-step.S fails with an assembler error, as a result
of a change to reading symbol names made by:
http://sourceware.org/ml/binutils-cvs/2012-05/msg00199.html

This patch fixes the use of .global directives in gdb.arch/arm-disp-step.S
by inserting the missing labels.

Thanks,
Greta

2012-06-14  Greta Yorsh  <Greta.Yorsh@arm.com>

	* gdb.arch/arm-disp-step.S: Fix use of .global directives.


[-- Attachment #2: test-gdb-disp-step.patch.txt --]
[-- Type: text/plain, Size: 819 bytes --]

diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.S b/gdb/testsuite/gdb.arch/arm-disp-step.S
index 423edc0..09d1663 100644
--- a/gdb/testsuite/gdb.arch/arm-disp-step.S
+++ b/gdb/testsuite/gdb.arch/arm-disp-step.S
@@ -110,7 +110,7 @@ test_ret:
 	.type test_branch, %function
 test_branch:
 	b	L_branch
-	.global
+	.global L_branch
 L_branch:
 	bx lr
 	.size test_branch, .-test_branch
@@ -124,7 +124,7 @@ L_branch:
 test_ldr_pc:
 	ldr	r1, [pc, #0]
 
-	.global
+	.global test_ldr_pc_ret
 test_ldr_pc_ret:
 	bx lr
 	.size test_ldr_pc, .-test_ldr_pc
@@ -137,10 +137,10 @@ test_ldm_stm_pc:
 	ldmia	sp!, {r0, r1}
 	ldr	r0, .L1
 	stmdb	sp!, {r0}
-	.global
+	.global test_ldm_pc
 test_ldm_pc:
 	ldmia	sp!, {pc}
-	.global
+	.global test_ldm_stm_pc_ret
 test_ldm_stm_pc_ret:
 	bx lr
 	.align	2

             reply	other threads:[~2012-06-18 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 15:32 Greta Yorsh [this message]
2012-06-25 12:45 ` Greta Yorsh
2012-06-25 12:47 ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901cd4d67$aa3654b0$fea2fe10$@Yorsh@arm.com' \
    --to=greta.yorsh@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).