From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9109 invoked by alias); 4 Aug 2010 07:27:43 -0000 Received: (qmail 9093 invoked by uid 22791); 4 Aug 2010 07:27:42 -0000 X-SWARE-Spam-Status: No, hits=1.0 required=5.0 tests=AWL,BAYES_50,KAM_STOCKGEN,MSGID_MULTIPLE_AT,TW_BJ X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Aug 2010 07:27:01 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o747Qiw4046555 ; Wed, 4 Aug 2010 09:26:44 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms7.u-strasbg.fr [IPv6:2001:660:2402:d::16]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o747Qhq8038165 ; Wed, 4 Aug 2010 09:26:44 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o747QgqD003877 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 4 Aug 2010 09:26:43 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'sami wagiaalla'" , References: <4C582E25.1030505@redhat.com> In-Reply-To: <4C582E25.1030505@redhat.com> Subject: RE: [patch] create and use symbol_set_language Date: Wed, 04 Aug 2010 07:27:00 -0000 Message-ID: <000c01cb33a6$89450260$9bcf0720$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00015.txt.bz2 Hi Sami, I just looked at your patch, which seems quite straightforward. Nevertheless, it seems that=20 it contains a change that is not commented: @@ -393,13 +393,11 @@ symbol_get_demangled_name (const struct general_symbol_info *gsymbol) /* Initialize the language dependent portion of a symbol depending upon the language for the symbol. */ void -symbol_init_language_specific (struct general_symbol_info *gsymbol, - enum language language) +symbol_set_language (struct general_symbol_info *gsymbol, + enum language language) { - gsymbol->language =3D language; - if (gsymbol->language =3D=3D language_cplus - || gsymbol->language =3D=3D language_d + if (gsymbol->language =3D=3D language_d || gsymbol->language =3D=3D language_java || gsymbol->language =3D=3D language_objc || gsymbol->language =3D=3D language_fortran) The removal of the 'gsymbol->language =3D=3D language_cplus' condition seems to be outside of the scope of the patch you describe, which seems otherwise quite straightforward.=20 Could you please comment on the reason of that specific change? Is it really part of that patch or shouldn't it be submitted separately? I must confess that I didn't even try to look at the source code after the 'if', but just reacted quickly on something that seem 'off topic' as compared to your patch description. Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de sami wagiaalla > Envoy=E9=A0: Tuesday, August 03, 2010 4:57 PM > =C0=A0: gdb-patches@sourceware.org > Objet=A0: [patch] create and use symbol_set_language >=20 > This patch renames SYMBOL_INIT_LANGUAGE_SPECIFIC to SYMBOL_SET_LANGUAGE > and symbol_init_language_specific to symbol_set_language, and uses them > everywhere the language of a symbol is set. Usually through > SYMBOL_LANGUAGE (sym) =3D language >=20 > This was tested by running the test suit on F13 with gcc 4.4.4 on x8664 > no regressions. >=20 > Let me know what you think. >=20 >=20 > Sami