From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFC] display names of explicit typedefs for 'info types'
Date: Wed, 23 Jun 2010 15:52:00 -0000 [thread overview]
Message-ID: <000f01cb12ec$194f4b80$4bede280$@muller@ics-cnrs.unistra.fr> (raw)
I was always puzzled by the fact that info types
did sometime not list types that I knew existed.
The problem is that for types defined in C using `typedef '
only the definition part was displayed, but not the name of
the type itself.
This small patch fixes that 'mis-feature'...
I was expecting lots of failures in the testsuite,
but was surprised to find no change that I could relate to the patch...
The following tiny example:
>>>>>Start
typedef volatile int volint;
typedef int myint;
volint vol;
myint my;
int
main ()
{
vol = 5;
my = 8;
return 0;
}
>>>>>End
gives currently (compiled with stabs debug info)
typedef int; (Repeated twice)
typedef volatile int;
With the patch, I get:
typedef int;
typedef int myint;
typedef volatile int volint;
Note that the output of 'info var' is not really consistent:
(gdb) info var
myint my;
volatile int vol;
but this is not changed by my patch, and is the same as before..
(gdb) ptype my
type = int
Here again, the original typedef name is completely lost ...
Comments welcome,
Pierre Muller
Pascal language support maintainer for GDB
2010-06-22 Pierre Muller <muller@ics.u-strasbg.fr>
* c-typeprint.c (c_print_typedef): Append new type name for
typedefs.
Index: src/gdb/c-typeprint.c
===================================================================
RCS file: /cvs/src/src/gdb/c-typeprint.c,v
retrieving revision 1.58
diff -u -p -r1.58 c-typeprint.c
--- src/gdb/c-typeprint.c 21 Jun 2010 18:01:50 -0000 1.58
+++ src/gdb/c-typeprint.c 22 Jun 2010 22:36:06 -0000
@@ -107,7 +107,8 @@ c_print_typedef (struct type *type, stru
type_print (type, "", stream, 0);
if (TYPE_NAME ((SYMBOL_TYPE (new_symbol))) == 0
|| strcmp (TYPE_NAME ((SYMBOL_TYPE (new_symbol))),
- SYMBOL_LINKAGE_NAME (new_symbol)) != 0)
+ SYMBOL_LINKAGE_NAME (new_symbol)) != 0
+ || TYPE_CODE (SYMBOL_TYPE (new_symbol)) == TYPE_CODE_TYPEDEF)
fprintf_filtered (stream, " %s", SYMBOL_PRINT_NAME (new_symbol));
fprintf_filtered (stream, ";\n");
}
next reply other threads:[~2010-06-23 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 15:52 Pierre Muller [this message]
2010-06-23 16:58 ` Michael Snyder
[not found] <37197.5782713436$1277308354@news.gmane.org>
2010-06-24 16:56 ` Tom Tromey
2010-06-25 7:36 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01cb12ec$194f4b80$4bede280$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).