* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
@ 2015-07-17 22:59 Doug Evans
2015-07-20 17:07 ` Steve Ellcey
0 siblings, 1 reply; 8+ messages in thread
From: Doug Evans @ 2015-07-17 22:59 UTC (permalink / raw)
To: sellcey, Eli Zaretskii; +Cc: gdb-patches
Doug Evans writes:
> On Fri, Jul 17, 2015 at 3:30 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
> > On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote:
> >
> >> 2015-07-16 Doug Evans <dje@google.com>
> >>
> >> * stabs.texinfo: @include gdb-cfg.texi.
> >>
> >> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo
> >> index 15c4152..c4ea037 100644
> >> --- a/gdb/doc/stabs.texinfo
> >> +++ b/gdb/doc/stabs.texinfo
> >> @@ -3,6 +3,10 @@
> >> @setchapternewpage odd
> >> @settitle STABS
> >>
> >> +@c man begin INCLUDE
> >> +@include gdb-cfg.texi
> >> +@c man end
> >> +
> >> @c @finalout
> >>
> >> @c This is a dir.info fragment to support semi-automated addition of
> >
> > This patch breaks my parallel gdb builds (though the bug may be a
latent
> > one that this change finally causes to trigger). On my machine my
> > parallel GDB build dies with:
> >
> > ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory.
> >
> > And then later in the log I see:
> >
> > mv GDBvn.new GDBvn.texi
> >
> > I think there is a missing dependency in the doc/Makefile.in to say
that
> > GDBvn.texi needs to be built before gdb-cfg.texi.
>
> Bleah.
> I think we just need to update STABS_DOC_BUILD_INCLUDES
> to be like GDB_DOC_BUILD_INCLUDES.
> I'll take care of it.
>
> Thanks for the report.
2015-07-17 Doug Evans <dje@google.com>
* Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index bd30a81..85ed95b 100644
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -143,7 +143,9 @@ GDB_DOC_FILES = \
# Stabs manual: All files
STABS_DOC_SOURCE_INCLUDES = \
$(srcdir)/fdl.texi
-STABS_DOC_BUILD_INCLUDES =
+STABS_DOC_BUILD_INCLUDES = \
+ gdb-cfg.texi \
+ GDBvn.texi
STABS_DOC_FILES = \
$(srcdir)/stabs.texinfo \
$(STABS_DOC_SOURCE_INCLUDES) \
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
2015-07-17 22:59 [doc RFA] stabs.texinfo: @include gdb-cfg.texi Doug Evans
@ 2015-07-20 17:07 ` Steve Ellcey
2015-07-20 17:09 ` Doug Evans
0 siblings, 1 reply; 8+ messages in thread
From: Steve Ellcey @ 2015-07-20 17:07 UTC (permalink / raw)
To: Doug Evans; +Cc: Eli Zaretskii, gdb-patches
On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote:
> 2015-07-17 Doug Evans <dje@google.com>
>
> * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
>
> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
> index bd30a81..85ed95b 100644
> --- a/gdb/doc/Makefile.in
> +++ b/gdb/doc/Makefile.in
> @@ -143,7 +143,9 @@ GDB_DOC_FILES = \
> # Stabs manual: All files
> STABS_DOC_SOURCE_INCLUDES = \
> $(srcdir)/fdl.texi
> -STABS_DOC_BUILD_INCLUDES =
> +STABS_DOC_BUILD_INCLUDES = \
> + gdb-cfg.texi \
> + GDBvn.texi
> STABS_DOC_FILES = \
> $(srcdir)/stabs.texinfo \
> $(STABS_DOC_SOURCE_INCLUDES) \
Doug, are you waiting for an OK from someone before checking this in? I
tested the patch locally and it fixed my build problem but it doesn't
look like it has been checked in yet.
Steve Ellcey
sellcey@imgtec.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
2015-07-20 17:07 ` Steve Ellcey
@ 2015-07-20 17:09 ` Doug Evans
2015-07-20 17:17 ` Steve Ellcey
0 siblings, 1 reply; 8+ messages in thread
From: Doug Evans @ 2015-07-20 17:09 UTC (permalink / raw)
To: sellcey; +Cc: Eli Zaretskii, gdb-patches
On Mon, Jul 20, 2015 at 10:07 AM, Steve Ellcey <sellcey@imgtec.com> wrote:
> On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote:
>
>> 2015-07-17 Doug Evans <dje@google.com>
>>
>> * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
>>
>> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
>> index bd30a81..85ed95b 100644
>> --- a/gdb/doc/Makefile.in
>> +++ b/gdb/doc/Makefile.in
>> @@ -143,7 +143,9 @@ GDB_DOC_FILES = \
>> # Stabs manual: All files
>> STABS_DOC_SOURCE_INCLUDES = \
>> $(srcdir)/fdl.texi
>> -STABS_DOC_BUILD_INCLUDES =
>> +STABS_DOC_BUILD_INCLUDES = \
>> + gdb-cfg.texi \
>> + GDBvn.texi
>> STABS_DOC_FILES = \
>> $(srcdir)/stabs.texinfo \
>> $(STABS_DOC_SOURCE_INCLUDES) \
>
> Doug, are you waiting for an OK from someone before checking this in? I
> tested the patch locally and it fixed my build problem but it doesn't
> look like it has been checked in yet.
Hi.
I checked it in this morning (to trunk and branch).
^ permalink raw reply [flat|nested] 8+ messages in thread
* [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
@ 2015-07-16 16:31 Doug Evans
2015-07-16 16:34 ` Eli Zaretskii
2015-07-17 22:30 ` Steve Ellcey
0 siblings, 2 replies; 8+ messages in thread
From: Doug Evans @ 2015-07-16 16:31 UTC (permalink / raw)
To: eliz, gdb-patches
Hi.
"make info" is currently giving the following warning:
makeinfo -DHAVE_MAKEINFO_CLICK -I ../../../random-cleanup/gdb/doc -o
stabs.info ../../../random-cleanup/gdb/doc/stabs.texinfo
../../../random-cleanup/gdb/doc/stabs.texinfo:4065: warning: undefined
flag: GDBN
This needs to go into the 7.10 branch as well.
2015-07-16 Doug Evans <dje@google.com>
* stabs.texinfo: @include gdb-cfg.texi.
diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo
index 15c4152..c4ea037 100644
--- a/gdb/doc/stabs.texinfo
+++ b/gdb/doc/stabs.texinfo
@@ -3,6 +3,10 @@
@setchapternewpage odd
@settitle STABS
+@c man begin INCLUDE
+@include gdb-cfg.texi
+@c man end
+
@c @finalout
@c This is a dir.info fragment to support semi-automated addition of
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
2015-07-16 16:31 Doug Evans
@ 2015-07-16 16:34 ` Eli Zaretskii
2015-07-17 22:30 ` Steve Ellcey
1 sibling, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2015-07-16 16:34 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> Date: Thu, 16 Jul 2015 16:30:57 +0000
> From: Doug Evans <dje@google.com>
>
> "make info" is currently giving the following warning:
>
> makeinfo -DHAVE_MAKEINFO_CLICK -I ../../../random-cleanup/gdb/doc -o
> stabs.info ../../../random-cleanup/gdb/doc/stabs.texinfo
> ../../../random-cleanup/gdb/doc/stabs.texinfo:4065: warning: undefined
> flag: GDBN
>
> This needs to go into the 7.10 branch as well.
Thanks, please do.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
2015-07-16 16:31 Doug Evans
2015-07-16 16:34 ` Eli Zaretskii
@ 2015-07-17 22:30 ` Steve Ellcey
2015-07-17 22:38 ` Doug Evans
1 sibling, 1 reply; 8+ messages in thread
From: Steve Ellcey @ 2015-07-17 22:30 UTC (permalink / raw)
To: Doug Evans; +Cc: eliz, gdb-patches
On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote:
> 2015-07-16 Doug Evans <dje@google.com>
>
> * stabs.texinfo: @include gdb-cfg.texi.
>
> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo
> index 15c4152..c4ea037 100644
> --- a/gdb/doc/stabs.texinfo
> +++ b/gdb/doc/stabs.texinfo
> @@ -3,6 +3,10 @@
> @setchapternewpage odd
> @settitle STABS
>
> +@c man begin INCLUDE
> +@include gdb-cfg.texi
> +@c man end
> +
> @c @finalout
>
> @c This is a dir.info fragment to support semi-automated addition of
This patch breaks my parallel gdb builds (though the bug may be a latent
one that this change finally causes to trigger). On my machine my
parallel GDB build dies with:
./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory.
And then later in the log I see:
mv GDBvn.new GDBvn.texi
I think there is a missing dependency in the doc/Makefile.in to say that
GDBvn.texi needs to be built before gdb-cfg.texi.
Steve Ellcey
sellcey@imgtec.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [doc RFA] stabs.texinfo: @include gdb-cfg.texi.
2015-07-17 22:30 ` Steve Ellcey
@ 2015-07-17 22:38 ` Doug Evans
0 siblings, 0 replies; 8+ messages in thread
From: Doug Evans @ 2015-07-17 22:38 UTC (permalink / raw)
To: sellcey; +Cc: Eli Zaretskii, gdb-patches
On Fri, Jul 17, 2015 at 3:30 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
> On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote:
>
>> 2015-07-16 Doug Evans <dje@google.com>
>>
>> * stabs.texinfo: @include gdb-cfg.texi.
>>
>> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo
>> index 15c4152..c4ea037 100644
>> --- a/gdb/doc/stabs.texinfo
>> +++ b/gdb/doc/stabs.texinfo
>> @@ -3,6 +3,10 @@
>> @setchapternewpage odd
>> @settitle STABS
>>
>> +@c man begin INCLUDE
>> +@include gdb-cfg.texi
>> +@c man end
>> +
>> @c @finalout
>>
>> @c This is a dir.info fragment to support semi-automated addition of
>
> This patch breaks my parallel gdb builds (though the bug may be a latent
> one that this change finally causes to trigger). On my machine my
> parallel GDB build dies with:
>
> ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory.
>
> And then later in the log I see:
>
> mv GDBvn.new GDBvn.texi
>
> I think there is a missing dependency in the doc/Makefile.in to say that
> GDBvn.texi needs to be built before gdb-cfg.texi.
Bleah.
I think we just need to update STABS_DOC_BUILD_INCLUDES
to be like GDB_DOC_BUILD_INCLUDES.
I'll take care of it.
Thanks for the report.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-07-20 17:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-17 22:59 [doc RFA] stabs.texinfo: @include gdb-cfg.texi Doug Evans
2015-07-20 17:07 ` Steve Ellcey
2015-07-20 17:09 ` Doug Evans
2015-07-20 17:17 ` Steve Ellcey
-- strict thread matches above, loose matches on Subject: below --
2015-07-16 16:31 Doug Evans
2015-07-16 16:34 ` Eli Zaretskii
2015-07-17 22:30 ` Steve Ellcey
2015-07-17 22:38 ` Doug Evans
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).