From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127499 invoked by alias); 22 Jan 2016 01:06:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127467 invoked by uid 89); 22 Jan 2016 01:06:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=SAL X-HELO: mail-pf0-f202.google.com Received: from mail-pf0-f202.google.com (HELO mail-pf0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 22 Jan 2016 01:06:08 +0000 Received: by mail-pf0-f202.google.com with SMTP id 65so5884549pfd.0 for ; Thu, 21 Jan 2016 17:06:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to :content-type; bh=Io1oTgs8FqHPilNv2zn4rpKJ7N1sfcbPNn0xSVym6wc=; b=KLFDteBSgS1cyRjikt+NxT42SiS7J0S8j6RWv/qay8o/xThj6mmhduwL0kMUlrK3dc FE10nWeuscNOMsPvRmhrO41D8MmVUJWS4pZuzV0YLs6Zn/GZxAxEPO8yO5RifWfSHy5u z3+EBPg0iGsErosZ2AsmHLVwROjlOFX0VbWHjMO8XCTLh1PUjZSNAguJrm+nOqlpS0I+ iVdN6m8QdMTe7f50bs0BwenSYP0BlOii3MaS9LGIuYZRy73TA40KMOU6oOGNWE/K+tkf 0r4ITNl7AscntqPbdd7f54JThxatTF+UNVIVKtZxu2SBJ+pd2oU9vFNUurMYk4ec4tmR j4Ew== X-Gm-Message-State: AG10YOTzsryx2tLzhNvngAF07pJAusEytIjHr/iaLfVyLsMYMYPAH+3lCPzaP1q2SvirDRUPtypePQs3mK0/vVTX0vcyBycrl2tf6fVNUEAQMAnKSGFfJTQFgOz2DilJZoXpiiamqi/E0/XevVliYivmjZlvi893Gac8DESqsv2uia80nkzgCw== MIME-Version: 1.0 X-Received: by 10.98.1.215 with SMTP id 206mr288651pfb.1.1453424766936; Thu, 21 Jan 2016 17:06:06 -0800 (PST) Message-ID: <001a1143804ef139a60529e1d2c1@google.com> Date: Fri, 22 Jan 2016 01:06:00 -0000 Subject: [OB PATCH] breakpoint.c (init_breakpoint_sal): Add comment. From: Doug Evans To: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00552.txt.bz2 Hi. While digging deeper into https://sourceware.org/ml/gdb-patches/2016-01/msg00497.html I was reading init_breakpoint_sal, trying to make sense of it. This comment helps a bit. 2016-01-21 Doug Evans * breakpoint.c (init_breakpoint_sal): Add comment. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 3aac26c..7b610ef 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -9233,7 +9233,8 @@ update_dprintf_commands (char *args, int from_tty, /* Create a breakpoint with SAL as location. Use LOCATION as a description of the location, and COND_STRING - as condition expression. */ + as condition expression. If LOCATION is NULL then create an + "address location" from the address in the SAL. */ static void init_breakpoint_sal (struct breakpoint *b, struct gdbarch *gdbarch,