From: "Doug Evans via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix scm-ports.exp regression
Date: Fri, 05 Jan 2018 17:59:00 -0000 [thread overview]
Message-ID: <001a114e70220867bc05620b37e3@google.com> (raw)
Tom Tromey writes:
> In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan
> pointed out that the scalar printing patches caused a regression in
> scm-ports.exp on x86.
>
> I think the simplest fix is to use "print/u" rather than "print/d" to
> get the value of sp_reg in the test case.
>
> Tested on x86-64 Fedora 26 using an ordinary build and also a -m32
> build.
>
> 2018-01-03 Tom Tromey <tom@tromey.com>
>
> * gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to
> compute sp_reg.
LGTM
next reply other threads:[~2018-01-05 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 17:59 Doug Evans via gdb-patches [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-03 18:20 Tom Tromey
2018-01-05 17:01 ` Pedro Alves
2018-01-09 18:27 ` Tom Tromey
2018-01-15 16:51 ` Pedro Alves
2018-01-15 18:17 ` Tom Tromey
2018-01-15 20:59 ` Sergio Durigan Junior
2018-01-15 22:10 ` Tom Tromey
2018-01-16 7:39 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=001a114e70220867bc05620b37e3@google.com \
--to=gdb-patches@sourceware.org \
--cc=dje@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).