From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68642 invoked by alias); 5 Jan 2018 17:59:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68632 invoked by uid 89); 5 Jan 2018 17:59:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=H*MI:google, H*M:google X-HELO: mail-qk0-f202.google.com Received: from mail-qk0-f202.google.com (HELO mail-qk0-f202.google.com) (209.85.220.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 17:59:52 +0000 Received: by mail-qk0-f202.google.com with SMTP id d125so3267805qkb.8 for ; Fri, 05 Jan 2018 09:59:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc; bh=nU8JVYYLPPn9ZMwy7YRmHSryBm6fODjnablmMzfU3LA=; b=nJtAfhE5jujN/Zjji6Ku0+nP29obfvBARSz9YcKdC7kEOPHRCB/PcCy6o8xfioRHKM 6Cthl/CLHmZcXQC5qe6HxQErMJMC7wTSVP1tvZXuhz9EbA2O68x8MeNXIZmnbEIMnvjC nzx11X/0bXCuHZKnY2NXuV8WgYme6CtoOixSf4mnkkNAYMmBwPTw8twmOOgX+X4O/Tjq a3lbAc2jMTkcc2t5n3P4RnNvkHfa9ml7ExwnH9q/RolsUGMo/OJ2yZ5AZvm0TEc0SHxl CYpkYjvvc9o3nIEYcesEFB3Bl4FaKgDh4XLMA/VviPkLQkrbefiW+fFmfarrGgRt4NSv Gsyg== X-Gm-Message-State: AKwxytfHhHy+yv8caa8Kux+ZpTVuqXRnjgaJx3SQKifdUsklmqKc2eXC 8MO5hZqp9trf5P5SEuzBK5+PB/0= X-Google-Smtp-Source: ACJfBov+snJCQh/B1jHlSj5vVbbtQVaS4bGJ/HfHTWPCzq/mqZKuwxZbeV23rMgdUfyVuMGYiujDie0= MIME-Version: 1.0 X-Received: by 10.55.71.8 with SMTP id u8mr2740286qka.14.1515175190976; Fri, 05 Jan 2018 09:59:50 -0800 (PST) Message-ID: <001a114e70220867bc05620b37e3@google.com> Date: Fri, 05 Jan 2018 17:59:00 -0000 Subject: Re: [RFA] Fix scm-ports.exp regression From: "Doug Evans via gdb-patches" Reply-To: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00107.txt.bz2 Tom Tromey writes: > In https://sourceware.org/ml/gdb-patches/2017-12/msg00215.html, Jan > pointed out that the scalar printing patches caused a regression in > scm-ports.exp on x86. > > I think the simplest fix is to use "print/u" rather than "print/d" to > get the value of sp_reg in the test case. > > Tested on x86-64 Fedora 26 using an ordinary build and also a -m32 > build. > > 2018-01-03 Tom Tromey > > * gdb.guile/scm-ports.exp (test_mem_port_rw): Use get_valueof to > compute sp_reg. LGTM