From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105321 invoked by alias); 21 May 2015 23:36:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105312 invoked by uid 89); 21 May 2015 23:36:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ig0-f201.google.com Received: from mail-ig0-f201.google.com (HELO mail-ig0-f201.google.com) (209.85.213.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 May 2015 23:36:14 +0000 Received: by igdh15 with SMTP id h15so1601581igd.1 for ; Thu, 21 May 2015 16:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc :content-type; bh=EMgQwg6oX3MG1z7cKlupH5pSSby+JKujskWyLUO7mwo=; b=Eq4bgY+nTS2j73qGi6LlPCHWMWLjHFahC4juXDP4iDWBg6CFfG8phDXgMwdmLBBrh5 NMTJ0RuRJiYctgFXl/FZURN1iZTHkyFOGlsl031A5tx8a8pl0PYde11bFukS/bMLCPbQ mol4vOcJ/koqUSHQP6ogV6fJs6WWYCz5v28xx+tHylevuG2ko4D0vAc/nrdwPSrWdgje 0A/2DK6irGW0k5tGnWVhg6eqtOIdjkCfDLc7GVGLDTXJimDRgW72a1uHy4eKkxuvLKLm X7PUO01SPCiwBXniItzcm+TyEX7eWy7CL8H3FVLNRW8SW15yz8VyVzrk7GWUUpRxKPAk ln2Q== X-Gm-Message-State: ALoCoQnuntYBocYFaJQDvB+dZs4iQK2OjHVCE+E699hSGoeTNA1ogA15knENaBLaxtKZSlysjKBJ MIME-Version: 1.0 X-Received: by 10.182.236.197 with SMTP id uw5mr6782635obc.32.1432251372805; Thu, 21 May 2015 16:36:12 -0700 (PDT) Message-ID: <001a11c35e5c4e462c0516a002e3@google.com> Date: Thu, 21 May 2015 23:36:00 -0000 Subject: Re: [PATCH v2 05/18] Implement completion limiting for ada_make_symbol_completion_list. From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00582.txt.bz2 Keith Seitz writes: > This patch converts the one Ada completion(-related) function, > symbol_completion_add, to use maybe_add_completion, and tests have > been added to exercise this newly implemented behavior. > > gdb/ChangeLog > > * ada-lang.c (symbol_completion_add): Return > add_completion_status instead of void. > Use add_completion and return the status of this function. > (ada_make_symbol_completion_list): If symbol_completion_add > returns that maximum completions have been reached, stop > looking for completions and return the list. > > gdb/testsuite/ChangeLog > > * gdb.ada/complete.exp (limit_multi_line): New procedure. > Update existing tests for source changes. > Add additional tests for new types. > Add tests for completion limiting. > * gdb.ada/complete/foo.adb (Repeat_Variable_1, Repeat_Variable_2, > Repeat_Variable_3, Repeat_Variable_4): Define. > * gdb.ada/complete/pck.ads (Repeat_Variable_1, Repeat_Variable_2) > (Repeat_Variable_3, Repeat_Variable_4): Declare. > (Repeated_1, Repeated_2, Repeated_3, Repeated_4): Define. > --- > gdb/ada-lang.c | 56 +++++++++--- > gdb/testsuite/gdb.ada/complete.exp | 144 ++++++++++++++++++++++++++++++++ > gdb/testsuite/gdb.ada/complete/foo.adb | 4 + > gdb/testsuite/gdb.ada/complete/pck.ads | 12 +++ > 4 files changed, 199 insertions(+), 17 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index e5469c0..fd824ee 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -6122,8 +6122,9 @@ symbol_completion_match (const char *sym_name, > encoded formed (in which case the completion should also be > encoded). */ > > -static void > +static enum add_completion_status > symbol_completion_add (VEC(char_ptr) **sv, > + struct completer_data *cdata, > const char *sym_name, > const char *text, int text_len, > const char *orig_text, const char *word, > @@ -6134,7 +6135,7 @@ symbol_completion_add (VEC(char_ptr) **sv, > char *completion; > > if (match == NULL) > - return; > + return 0; return ADD_COMPLETION_OK?