From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: RE: [RFA 2/3] Import vsnprintf from libiberty if not available.
Date: Thu, 24 Jun 2010 12:40:00 -0000 [thread overview]
Message-ID: <001b01cb139a$541959f0$fc4c0dd0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <001a01cb1395$e6b04e40$b410eac0$@muller@ics-cnrs.unistra.fr>
Nevermind,
I finally found the answer myself,
by looking more deeply into gdbserver/configure
The inclusion already works for memmem.o
by adding memmem.o to LIBOBJS around line 3812
but that part did not need any change (as it use already $ac_func)
where the lines just before were changed by
your patch because they used MEMMEM/memmem explicitly
instead of $ac_xxx variables.
As LIBOBJS didn't appear at all in your patch,
I had a hard time find out how the objects
are added to the needed list!
Pierre
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : Thursday, June 24, 2010 2:08 PM
> À : 'Joel Brobecker'; gdb-patches@sourceware.org
> Objet : RE: [RFA 2/3] Import vsnprintf from libiberty if not available.
>
> Hi Joel,
>
>
> I am probably missing a part of your patch...
>
> I do not understand what triggers the compilation of the
> vasprint.o and vsnprintf.o objects are added to the list
> of required objects to compile and link for the final
> gdbserver executable.
>
> I also saw not explicit reference to these objects
> in the third part of your patch.
>
> Is this inclusion hidden somewhere in your configure changes?
>
>
> Pierre Muller
> Pascal language support maintainer for GDB
>
>
next prev parent reply other threads:[~2010-06-24 12:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 17:46 Add support for ppc-lynxos to GDBserver Joel Brobecker
2010-06-23 17:46 ` [RFA 2/3] Import vsnprintf from libiberty if not available Joel Brobecker
2010-06-23 19:19 ` Joseph S. Myers
2010-06-24 12:08 ` Pierre Muller
2010-06-24 12:40 ` Pierre Muller [this message]
2010-06-23 17:46 ` [RFA 1/3] Generate regformats/rs6000/powerpc-32.dat Joel Brobecker
2010-06-23 17:46 ` [RFA 3/3] gdbserver support for powerpc-lynxos (4.x) Joel Brobecker
2010-07-27 16:13 ` Pedro Alves
2010-08-31 19:38 ` Joel Brobecker
2010-08-31 20:24 ` Pedro Alves
2010-09-01 18:36 ` Joel Brobecker
2010-09-01 18:42 ` Pedro Alves
2010-09-01 19:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01cb139a$541959f0$fc4c0dd0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).