From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2130 invoked by alias); 24 Jun 2010 12:40:01 -0000 Received: (qmail 2101 invoked by uid 22791); 24 Jun 2010 12:39:58 -0000 X-SWARE-Spam-Status: No, hits=1.5 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT,RCVD_IN_JMF_BL X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 12:39:53 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o5OCdZxa042296 ; Thu, 24 Jun 2010 14:39:35 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms8.u-strasbg.fr [IPv6:2001:660:2402:d::17]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o5OCdZtZ078194 ; Thu, 24 Jun 2010 14:39:35 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o5OCdYZv032781 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 24 Jun 2010 14:39:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" , References: <1277315177-17869-1-git-send-email-brobecker@adacore.com> <1277315177-17869-3-git-send-email-brobecker@adacore.com> <001a01cb1395$e6b04e40$b410eac0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001a01cb1395$e6b04e40$b410eac0$@muller@ics-cnrs.unistra.fr> Subject: RE: [RFA 2/3] Import vsnprintf from libiberty if not available. Date: Thu, 24 Jun 2010 12:40:00 -0000 Message-ID: <001b01cb139a$541959f0$fc4c0dd0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00522.txt.bz2 Nevermind,=20 I finally found the answer myself, by looking more deeply into gdbserver/configure The inclusion already works for memmem.o by adding memmem.o to LIBOBJS around line 3812 but that part did not need any change (as it use already $ac_func) where the lines just before were changed by your patch because they used MEMMEM/memmem explicitly instead of $ac_xxx variables. As LIBOBJS didn't appear at all in your patch, I had a hard time find out how the objects are added to the needed list! Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pierre Muller > Envoy=E9=A0: Thursday, June 24, 2010 2:08 PM > =C0=A0: 'Joel Brobecker'; gdb-patches@sourceware.org > Objet=A0: RE: [RFA 2/3] Import vsnprintf from libiberty if not available. >=20 > Hi Joel, >=20 >=20 > I am probably missing a part of your patch... >=20 > I do not understand what triggers the compilation of the > vasprint.o and vsnprintf.o objects are added to the list > of required objects to compile and link for the final > gdbserver executable. >=20 > I also saw not explicit reference to these objects > in the third part of your patch. >=20 > Is this inclusion hidden somewhere in your configure changes? >=20 >=20 > Pierre Muller > Pascal language support maintainer for GDB >=20 >=20