From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24043 invoked by alias); 21 Apr 2010 23:22:18 -0000 Received: (qmail 24033 invoked by uid 22791); 21 Apr 2010 23:22:18 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 23:22:13 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3LNLxid073769 ; Thu, 22 Apr 2010 01:21:59 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3LNLwTA009552 ; Thu, 22 Apr 2010 01:21:58 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3LNLv4l026880 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 22 Apr 2010 01:21:58 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: References: <11484.4708740295$1268865815@news.gmane.org> <83r5ngix6d.fsf@gnu.org> <15103.6087111153$1269298497@news.gmane.org> <006101cad0ec$cb7915d0$626b4170$%muller@ics-cnrs.unistra.fr> <83tyrwxy72.fsf@gnu.org> <000f01cad17e$7686f140$6394d3c0$%muller@ics-cnrs.unistra.fr> <83aatnxqhm.fsf@gnu.org> <002701cad513$e44a7420$acdf5c60$%muller@ics-cnrs.unistra.fr> <83fx38xydz.fsf@gnu.org> <001201cad75e$2ef3fcc0$8cdbf640$@muller@ics-cnrs.unistra.fr> <48335.255837492$1271407316@news.gmane.org> In-Reply-To: Subject: RE: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s' Date: Wed, 21 Apr 2010 23:22:00 -0000 Message-ID: <001e01cae1a9$7663e020$632ba060$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00718.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Thursday, April 22, 2010 12:49 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org; 'Eli Zaretskii' > Objet=A0: Re: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s' >=20 > >>>>> "Pierre" =3D=3D Pierre Muller > writes: >=20 > Pierre> Tom, > Pierre> would you have some time to > Pierre> take again a look at this? >=20 > This looks pretty good. A couple nits and it is ok. >=20 > >> + /* Multi-byte character types. */ >=20 > I think it is more clear to describe these as "wide" character types. > I have usually seen "multi-byte" used synonymously with "variable > length". >=20 > This comment appears twice. >=20 > >> + The case of strings is handled n decode_format, only explicit >=20 > Typo, s/n/in/ >=20 > Ok with those changes. Thanks. Thanks for the review, patch committed. Pierre